Hi Michael, I assume by "the Jira issue number" you mean "the Jira issue number, if the patch addresses one"
We won't have to file a bug for every patch we submit, right? Dan Στις 30 Απριλίου 2011 1:10 π.μ., ο χρήστης Michael MacFadden <[email protected]> έγραψε: > On a related note, we should also get in the habit of putting the Jira Issue > number in as well. When we move to SVN, Jira will automatically pick up the > reference in the commit message and show the source files that were changed > in relation to the bug / enhancement. > > > On Apr 29, 2011, at 7:46 AM, Daniel Danilatos wrote: > >> Great. Well then unless someone objects let's henceforth gently remind >> people of this practice until it becomes habit :) >> >> Dan >> >> Στις 29 Απριλίου 2011 7:01 μ.μ., ο χρήστης Yuri Z <[email protected]> έγραψε: >>> +1 >>> I ll start doing it from next commit. >>> >>> 2011/4/29 Lennard de Rijk <[email protected]> >>> >>>> Hi Daniel, >>>> >>>> On Fri, Apr 29, 2011 at 09:43, Daniel Danilatos <[email protected] >>>>> wrote: >>>> >>>>> I think it would be a good practice if everyone puts a link to the >>>>> code review in the commit message. This makes it very easy to see the >>>>> discussions/justifications that happened on a particular change. >>>>> >>>>> Thoughts? >>>>> >>>> >>>> I totally agree with this. During my time on the project I've always tried >>>> to indicate the number of the review in Rietveld and who reviewed it. It >>>> sounds like a very nice idea if this practice could be continued when we >>>> migrated to Apache. >>>> >>>> Greetings, >>>> Lennard >>>> >>> > >
