Hi, Something related to the text wrap again. I made some changes as per review comments in the Blip.css. When I try to build the code, I see a test case failure in org.waveprotocol.box.server.waveserver.WaveMapTest in line 389 which is
assertFalse(descCreatedOrdering.isOrdered(resultsAsc)); I somehow could not relate how this test case is related to the word wrap issue. When I comment out this line, the build works fine and the word wrap is working as expected. Could some one please help me understanding this, Am I doing something wrong or Do I need to fix this test case? Thanks for your time. Regards, Gokul On Fri, May 6, 2011 at 2:32 PM, Gokul Jeyapaul < [email protected]> wrote: > Hi Yuri et all, > > Thanks. I have set up the review environment. > > http://codereview.waveprotocol.org/585002 > > Looking forward for review comments. > > Regards, > Gk > > > On Tue, May 3, 2011 at 3:36 PM, Yuri Z <[email protected]> wrote: > >> Hi >> You just need a working Python installation on your Windows machine. I >> think you can find instructions on sites like >> http://www.python.org/download/windows/. >> >> >> 2011/5/3 Gokul Jeyapaul <[email protected]> >> >>> Hi Yuri et all, >>> >>> I am sorry, I am kind of a beginner with open source projects, so I >>> could not follow well on the steps there. I request some help in elaborating >>> the step 3 that is, >>> >>> Use the request_codereview script to set up a code review at >>> http://codereview.waveprotocol.org >>> >>> I see that request_codereview is a python script, I am not sure how to >>> use it to set the code review environment at >>> codereview.waveprotocol.org...also I am on a windows machine. Will I have to >>> switch over to Linux? >>> >>> Thanks, >>> Gk >>> >>> >>> On Fri, Apr 29, 2011 at 5:00 PM, Yuri Z <[email protected]> wrote: >>> >>>> Hi Gokul >>>> Thanks for doing this! >>>> The screenshot looks right, so I think you cam submit a patch for the >>>> change, see http://www.waveprotocol.org/get-involved for instructions. >>>> >>>> >>>> 2011/4/29 Gokul Jeyapaul <[email protected]> >>>> >>>>> Hi Yuri, >>>>> >>>>> I was looking at the issue 251 in the waib project and felt it was >>>>> good to start getting my hands dirty with, so I just wanted to try fixing >>>>> the issue in my local and see if the fix was what is expected. I just >>>>> tried >>>>> tweaking the Blip.css(the one you had mentioned in the comments) and got >>>>> the >>>>> word wrap work. >>>>> >>>>> I am attaching the screen shot of it. I just added >>>>> >>>>> word-wrap: break-word; >>>>> >>>>> to the contentContainer, replies and privateReplies class in the css. >>>>> I tested it with ff4 and IE7.0 seems working fine. >>>>> >>>>> I was also just wondering - the word wrap keeps the text in the blip >>>>> keep growing across multiple lines...so beyond a threshold they should be >>>>> stopped and appended with "...", and show whole text on mouse over? >>>>> >>>>> Or may be something similar. Again just an initiative to make myself >>>>> familiar with the code base. Thanks for your time and helping me out in >>>>> the >>>>> learning process. >>>>> >>>>> Regards, >>>>> Gk >>>>> >>>> >>> >
