> On 2011-10-24 12:05:03, Thomas Broyer wrote: > > /src/org/waveprotocol/box/server/rpc/ServerRpcProvider.java, line 345 > > <https://reviews.apache.org/r/2533/diff/1-3/?file=52348#file52348line345> > > > > Why use bit.ly URLs?
Changed to real URL. > On 2011-10-24 12:05:03, Thomas Broyer wrote: > > /test/org/waveprotocol/wave/crypto/CertpathTest.java, line 96 > > <https://reviews.apache.org/r/2533/diff/3/?file=52606#file52606line96> > > > > !? > > > > Does not seem related to our issue here. No... sorry. This is related with: https://issues.apache.org/jira/browse/WAVE-292 Removed in my new patch > On 2011-10-24 12:05:03, Thomas Broyer wrote: > > /third_party/codegen/socketio/README.google, line 2 > > <https://reviews.apache.org/r/2533/diff/3/?file=52608#file52608line2> > > > > Should be updated; maybe use the commit SHA-1 from your GitHub repo? Since my pull request to https://github.com/Ovea/Socket.IO-Java was accepted, I've changed the README with this url and this commit sha-1 instead. > On 2011-10-24 12:05:03, Thomas Broyer wrote: > > /third_party/runtime/socketio/README.google, line 2 > > <https://reviews.apache.org/r/2533/diff/3/?file=52637#file52637line2> > > > > Same here: use the commit SHA-1 from your GitHub repo? Same... - vjrj ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2533/#review2786 ----------------------------------------------------------- On 2011-10-24 14:39:57, vjrj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2533/ > ----------------------------------------------------------- > > (Updated 2011-10-24 14:39:57) > > > Review request for wave, Yuri Zelikov, Tad Glines, soren, and Nelson Silva. > > > Summary > ------- > > New chrome (14, 15) use the new websocket specification that is not support > by socketio-java (that uses socket-io.js 0.6). > > As a temporal solution (while the websocket stuff is more stable) this patch: > - Upgrades WIAB to use a 8 jetty version > - Upgrades socketio-java to use the same jetty version > - Enables both socket and socket-io in client side then if client supports > websocket it will connect via jetty and if not, it will use socket-io-java. > > For now, I did not removed use_socketio server parameter to make this patch > more clear. > > Yuri, can you add more reviewers? because I don't know the new usernames here. > > The binaries: > http://homes.ourproject.org/~vjrj/otros/patch-socketio.tgz > > > Diffs > ----- > > /.classpath 1187587 > /src/org/waveprotocol/box/server/robots/agent/passwd/PasswordRobot.java > 1187587 > /src/org/waveprotocol/box/server/rpc/AbstractWaveSocketIOServlet.java > PRE-CREATION > /src/org/waveprotocol/box/server/rpc/ServerRpcProvider.java 1187587 > /src/org/waveprotocol/box/server/rpc/SocketIOServerChannel.java 1187587 > /src/org/waveprotocol/box/server/rpc/WebSocketServerChannel.java 1187587 > /src/org/waveprotocol/box/webclient/client/WaveSocketFactory.java 1187587 > /src/org/waveprotocol/box/webclient/client/WebClient.java 1187587 > /third_party/codegen/socketio/COPYING PRE-CREATION > /third_party/codegen/socketio/README.google PRE-CREATION > /third_party/codegen/socketio/socketio-gwt-0.1-SNAPSHOT-sources.jar UNKNOWN > /third_party/codegen/socketio/socketio-gwt-0.1-SNAPSHOT.jar UNKNOWN > /third_party/runtime/jetty/jetty-client-7.1.6.v20100715.jar UNKNOWN > /third_party/runtime/jetty/jetty-client-8.0.0.v20110901.jar UNKNOWN > /third_party/runtime/jetty/jetty-continuation-7.1.6.v20100715.jar UNKNOWN > /third_party/runtime/jetty/jetty-continuation-8.0.0.v20110901.jar UNKNOWN > /third_party/runtime/jetty/jetty-http-7.1.6.v20100715.jar UNKNOWN > /third_party/runtime/jetty/jetty-http-8.0.0.v20110901.jar UNKNOWN > /third_party/runtime/jetty/jetty-io-7.1.6.v20100715.jar UNKNOWN > /third_party/runtime/jetty/jetty-io-8.0.0.v20110901.jar UNKNOWN > /third_party/runtime/jetty/jetty-security-7.1.6.v20100715.jar UNKNOWN > /third_party/runtime/jetty/jetty-security-8.0.0.v20110901.jar UNKNOWN > /third_party/runtime/jetty/jetty-server-7.1.6.v20100715.jar UNKNOWN > /third_party/runtime/jetty/jetty-server-8.0.0.v20110901.jar UNKNOWN > /third_party/runtime/jetty/jetty-servlet-7.1.6.v20100715.jar UNKNOWN > /third_party/runtime/jetty/jetty-servlet-8.0.0.v20110901.jar UNKNOWN > /third_party/runtime/jetty/jetty-servlets-7.1.6.v20100715.jar UNKNOWN > /third_party/runtime/jetty/jetty-servlets-8.0.0.v20110901.jar UNKNOWN > /third_party/runtime/jetty/jetty-util-7.1.6.v20100715.jar UNKNOWN > /third_party/runtime/jetty/jetty-util-8.0.0.v20110901.jar UNKNOWN > /third_party/runtime/jetty/jetty-webapp-7.1.6.v20100715.jar UNKNOWN > /third_party/runtime/jetty/jetty-webapp-8.0.0.v20110901.jar UNKNOWN > /third_party/runtime/jetty/jetty-websocket-7.1.6.v20100715.jar UNKNOWN > /third_party/runtime/jetty/jetty-websocket-8.0.0.v20110901.jar UNKNOWN > /third_party/runtime/jetty/jetty-xml-7.1.6.v20100715.jar UNKNOWN > /third_party/runtime/jetty/jetty-xml-8.0.0.v20110901.jar UNKNOWN > /third_party/runtime/jetty/servlet-api-2.5.jar UNKNOWN > /third_party/runtime/jetty/servlet-api-3.0.jar UNKNOWN > /third_party/runtime/socketio/README.google 1187587 > /third_party/runtime/socketio/socketio-core-0.1-SNAPSHOT-sources.jar > UNKNOWN > /third_party/runtime/socketio/socketio-core-0.1-SNAPSHOT.jar UNKNOWN > /third_party/runtime/socketio/socketio-java-src.jar UNKNOWN > /third_party/runtime/socketio/socketio-java.jar UNKNOWN > /third_party/runtime/socketio/socketio-jetty-0.1-SNAPSHOT-sources.jar > UNKNOWN > /third_party/runtime/socketio/socketio-jetty-0.1-SNAPSHOT.jar UNKNOWN > > Diff: https://reviews.apache.org/r/2533/diff > > > Testing > ------- > > To connect to WIAB correctly using firefox 7.0.1 and chormmium (15). > > > Thanks, > > vjrj > >
