----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2632/#review2931 -----------------------------------------------------------
Ship it! LGTM I'm new to this diff tool but it looks like some lines have trailing spaces. Please remove before submitting. /src/org/waveprotocol/box/server/waveserver/WaveServerModule.java <https://reviews.apache.org/r/2632/#comment6567> double underscore looks strange - soren On 2011-10-30 20:18:42, Yuri Zelikov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2632/ > ----------------------------------------------------------- > > (Updated 2011-10-30 20:18:42) > > > Review request for wave, Michael MacFadd, vjrj, and soren. > > > Summary > ------- > > Improves persistence logic and addresses some old TODOs. Most of the patch > was contributed by ([email protected]). > -Removes the requirement for persistExecutor being single threaded. > -Refines the persist() logic to make batch successive writes to storage. > -Injects shared instance of persistExecutor instead of creating one instance > per wavelet. > > > Diffs > ----- > > > /src/org/waveprotocol/box/server/waveserver/DeltaStoreBasedWaveletState.java > 1195229 > /src/org/waveprotocol/box/server/waveserver/WaveServerModule.java 1195229 > /test/org/waveprotocol/box/server/waveserver/WaveServerTest.java 1195229 > > Diff: https://reviews.apache.org/r/2632/diff > > > Testing > ------- > > yes. > > > Thanks, > > Yuri > >
