----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2662/#review3262 -----------------------------------------------------------
Ship it! I took a look at the latest patch. Looks good. I downloaded and applied. didn't see any issues. - Michael On 2011-11-01 20:16:43, Yuri Zelikov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2662/ > ----------------------------------------------------------- > > (Updated 2011-11-01 20:16:43) > > > Review request for wave, Michael MacFadd and soren. > > > Summary > ------- > > Improves persistence logic and addresses some old TODOs - part2. > This patch removes in-memory stored deltas and instead makes requests to the > persistent storage. It also handles eviction of persisted deltas. > > > Diffs > ----- > > > /src/org/waveprotocol/box/server/waveserver/DeltaStoreBasedSnapshotStore.java > 1195229 > > /src/org/waveprotocol/box/server/waveserver/DeltaStoreBasedWaveletState.java > 1196213 > /src/org/waveprotocol/box/server/waveserver/RuntimeIOException.java > PRE-CREATION > /src/org/waveprotocol/box/server/waveserver/WaveletContainerImpl.java > 1195229 > /src/org/waveprotocol/box/server/waveserver/WaveletState.java 1195229 > > Diff: https://reviews.apache.org/r/2662/diff > > > Testing > ------- > > > Thanks, > > Yuri > >
