----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2928/#review3501 -----------------------------------------------------------
In general, I think the code looks fine. Two questions. What is the use case that this is supporting and is there a JIRA issue? - Michael On 2011-11-23 23:13:59, Yuri Zelikov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2928/ > ----------------------------------------------------------- > > (Updated 2011-11-23 23:13:59) > > > Review request for wave, Michael MacFadden and vjrj. > > > Summary > ------- > > Adds support for the onGadgetStateChanged event to the Robot API > > > Diffs > ----- > > src/org/waveprotocol/box/server/robots/passive/EventGenerator.java f8ac84f > > Diff: https://reviews.apache.org/r/2928/diff > > > Testing > ------- > > > Thanks, > > Yuri > >
