> On 2011-11-25 15:44:55, Yuri Zelikov wrote: > > Unless anyone objects during the next 24 hoours, I will commit this patch.
Sorry, I was looking your review but I'm not familiarized with that part of code to give a solid feedback. Anyway decoupling sounds good to me. - vjrj ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2882/#review3513 ----------------------------------------------------------- On 2011-11-22 19:13:17, Yuri Zelikov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2882/ > ----------------------------------------------------------- > > (Updated 2011-11-22 19:13:17) > > > Review request for wave, Michael MacFadden, Tad Glines, and vjrj. > > > Summary > ------- > > Refactors the SearchService related classes to allow easier integration of > alternative search provider. Basically, the code responsible for digest > generation was decoupled from SearchService and moved into SearchProvider. > > > Diffs > ----- > > src/com/google/wave/api/SearchResult.java fea106b > src/com/google/wave/api/impl/GsonFactory.java 615a182 > src/org/waveprotocol/box/server/robots/operations/SearchService.java > b235232 > src/org/waveprotocol/box/server/waveserver/SearchProvider.java a2d55be > src/org/waveprotocol/box/server/waveserver/WaveDigester.java PRE-CREATION > src/org/waveprotocol/box/server/waveserver/WaveMap.java 1192103 > test/org/waveprotocol/box/server/robots/operations/SearchServiceTest.java > 5fb5e19 > test/org/waveprotocol/box/server/robots/operations/TestingWaveletData.java > PRE-CREATION > test/org/waveprotocol/box/server/waveserver/WaveDigesterTest.java > PRE-CREATION > test/org/waveprotocol/box/server/waveserver/WaveMapTest.java 82daafc > test/org/waveprotocol/box/server/waveserver/WaveServerTest.java 1147578 > > Diff: https://reviews.apache.org/r/2882/diff > > > Testing > ------- > > > Thanks, > > Yuri > >
