----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3128/#review3823 -----------------------------------------------------------
Ship it! LGTM (minor comment is that it looks like there are some trailing whitespaces in the new code). - Michael On 2011-12-09 22:34:21, Yuri Zelikov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3128/ > ----------------------------------------------------------- > > (Updated 2011-12-09 22:34:21) > > > Review request for wave and Michael MacFadden. > > > Summary > ------- > > Addresses TODO to move the thread counts from the code into server.config > properties. > It also sets the default for LISTENER_EXECUTOR_THREAD_COUNT to 1, since it > seems like bigger values can cause the "No conversations" error when trying > to open a new ave. > > > Diffs > ----- > > server-config.xml 705fc98 > server.config.example 3422769 > src/org/waveprotocol/box/server/CoreSettings.java f163cd4 > src/org/waveprotocol/box/server/ServerMain.java 3f773c3 > src/org/waveprotocol/box/server/ServerModule.java 29236c4 > src/org/waveprotocol/box/server/waveserver/WaveServerModule.java 39a524e > > Diff: https://reviews.apache.org/r/3128/diff > > > Testing > ------- > > > Thanks, > > Yuri > >
