> On 2011-12-07 17:31:21, Yuri Zelikov wrote: > > LGTM
Can you please close this review request? - Yuri ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3033/#review3704 ----------------------------------------------------------- On 2011-12-06 21:22:30, Ali Lown wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3033/ > ----------------------------------------------------------- > > (Updated 2011-12-06 21:22:30) > > > Review request for wave and Yuri Zelikov. > > > Summary > ------- > > Implements clearing sub/super text style when the clear formatting button is > pressed as suggested in WAVE-142. > > Works by adding verticalAlign attribute to existing list of styles to clear. > > > This addresses bug WAVE-142. > https://issues.apache.org/jira/browse/WAVE-142 > > > Diffs > ----- > > /src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/EditToolbar.java > 1211145 > > Diff: https://reviews.apache.org/r/3033/diff > > > Testing > ------- > > Compiled. Ran server, added text in a blip with sub + super styles. Selected > and clicked 'clear formatting button'. Style was removed. > > > Thanks, > > Ali > >
