> On 2012-01-11 19:08:15, Yuri Zelikov wrote: > > LGTM
Committed as r1230205 - Yuri ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3438/#review4313 ----------------------------------------------------------- On 2012-01-09 17:48:06, Ali Lown wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3438/ > ----------------------------------------------------------- > > (Updated 2012-01-09 17:48:06) > > > Review request for wave and Yuri Zelikov. > > > Summary > ------- > > Tiny bug fix that prevents the wave favicon being correctly loaded on the > authentication page if the url already contains a query string, since (eg. > Chrome) resolves it to > http://wave.eezysys.co.uk/auth/signin?r=/static/favicon.ico instead of > http://wave.eezysys.co.uk/static/favicon.ico > > All the other gxp pages contain the correct url to the favicon. > > > Diffs > ----- > > /src/org/waveprotocol/box/server/gxp/AuthenticationPage.gxp 1228763 > > Diff: https://reviews.apache.org/r/3438/diff > > > Testing > ------- > > URL resolved correctly after patch. > > > Thanks, > > Ali > >
