----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3512/#review4410 -----------------------------------------------------------
Hmm, I think I already implemented something like this for waveinabox.net as experimental feature. But then I removed all experimental features. And I didn't bother to submit it later... Too bad. Anyway, can you try my implementation and let me know which one you prefer? https://github.com/vega113/WaveInCloud/commit/6ff2f3b2c0b615cb70fe4fbdbde5022616b79407 - Yuri On 2012-01-16 21:23:00, Ali Lown wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3512/ > ----------------------------------------------------------- > > (Updated 2012-01-16 21:23:00) > > > Review request for wave, Yuri Zelikov and Lennard de Rijk. > > > Summary > ------- > > For waves with a title determined by the existing WaveTitleHandler code, this > renders it in the page's html title tag and in the blue space at the top of > the wave frame. > > Note: I went for extending the WaveSelectionEvent to pass a title along with > it, rather than trying to find the wave from the WaveRef, opening it and then > getting the title, because in future implementations of the backend logic > this is likely to force an IO operation (which is pointless since the callers > to WaveSelectionEvent seem to have the title readily available anyway). > > > Diffs > ----- > > /src/org/waveprotocol/box/webclient/client/HistoryChangeListener.java > 1230205 > /src/org/waveprotocol/box/webclient/client/WebClient.java 1230205 > /src/org/waveprotocol/box/webclient/client/events/WaveSelectionEvent.java > 1230205 > > /src/org/waveprotocol/box/webclient/client/events/WaveSelectionEventHandler.java > 1230205 > /src/org/waveprotocol/box/webclient/search/SearchPresenter.java 1230205 > > Diff: https://reviews.apache.org/r/3512/diff > > > Testing > ------- > > Works on my machine. :) > > > Thanks, > > Ali > >
