> On 2012-01-21 16:23:07, Ali Lown wrote: > > The patch itself looks fine. > > > > Why was the buffer size reduced? What has changed to allow it to be > > enlarged again?
I thought that the buffer size is related to frequent OutOfMemory exceptions I could see in the waveinabox.net since it was in the Socket.IO servlet code. After some more investigation it seems like the out of memory errors were caused by other things. - Yuri ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3578/#review4512 ----------------------------------------------------------- On 2012-01-21 16:09:06, Yuri Zelikov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3578/ > ----------------------------------------------------------- > > (Updated 2012-01-21 16:09:06) > > > Review request for wave, Michael MacFadden, vjrj, and Ali Lown. > > > Summary > ------- > > Returns the buffer size back to 1MB as it was before. > > > Diffs > ----- > > src/org/waveprotocol/box/server/rpc/ServerRpcProvider.java 3f8b43c > > Diff: https://reviews.apache.org/r/3578/diff > > > Testing > ------- > > Tested on my local computer. > > > Thanks, > > Yuri > >
