----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3577/#review4523 -----------------------------------------------------------
Committed as revision 1234538 - Yuri On 2012-01-21 15:59:13, Yuri Zelikov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3577/ > ----------------------------------------------------------- > > (Updated 2012-01-21 15:59:13) > > > Review request for wave, Michael MacFadden, vjrj, and Ali Lown. > > > Summary > ------- > > Removes blip auto focus and adds blip navigation buttons to the wave view > toolbar instead. The main motivation for this patch for to remove the blip > auto focus feature as it seems it had something to do with various client > side errors as mentioned in https://issues.apache.org/jira/browse/WAVE-307. > The auto focus patch introduced an early blips rendering using > blipQueue().flush() and probably this action in combination of subsequent > focusing on the blip and marking it as read made some race conditions even > worse and increased the probability of the errors. > The current patch reverted the blipQueue().flush()and automatic marking blips > as read. I also added a few navigation buttons to the wave view toolbar to > serve as compensation for removal of the auto focus feature. > > > Diffs > ----- > > src/org/waveprotocol/box/webclient/client/StageTwoProvider.java 323f065 > src/org/waveprotocol/box/webclient/client/StagesProvider.java 8a5355a > src/org/waveprotocol/wave/client/StageThree.java f31ed3b > src/org/waveprotocol/wave/client/StageTwo.java cf95e3e > > src/org/waveprotocol/wave/client/wavepanel/impl/focus/FocusBlipSelector.java > 2ccee48 > src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/ViewToolbar.java > f8504d3 > > Diff: https://reviews.apache.org/r/3577/diff > > > Testing > ------- > > Tested on my local computer and it works. Also tested using the Selenium > script from issue WAVE-307 - and encountered a lot less "No conversations" > issues than without this patch. > > > Thanks, > > Yuri > >
