Hey guys, There is DocHelper.getText() so you don't have to implement getting the whole text of the document yourself!
Also, how does this perform on large documents? Perhaps we should restrict the text search space to the vicinity of the current selection? Dan On Sat, Dec 31, 2011 at 6:49 PM, Yuri Zelikov <[email protected]> wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3294/#review4160 > ----------------------------------------------------------- > > > > /src/org/waveprotocol/wave/client/editor/impl/AutoLinker.java > <https://reviews.apache.org/r/3294/#comment9394> > > There are indentation inconsistencies in this class. Please keep the two > spaces indentation everywhere. > > > > /src/org/waveprotocol/wave/client/editor/impl/AutoLinker.java > <https://reviews.apache.org/r/3294/#comment9387> > > This import is unused. > > > > /src/org/waveprotocol/wave/client/editor/impl/AutoLinker.java > <https://reviews.apache.org/r/3294/#comment9388> > > This import is unused. > > > > /src/org/waveprotocol/wave/client/editor/impl/AutoLinker.java > <https://reviews.apache.org/r/3294/#comment9385> > > The indentation is different here. Should be two spaces. > > > > /src/org/waveprotocol/wave/client/editor/impl/AutoLinker.java > <https://reviews.apache.org/r/3294/#comment9386> > > Please allow one space after the double slash ant terminate the comment > with full stop > //Needed as an array to select individual ones later -> > // Needed as an array to select individual ones later. > > > > /src/org/waveprotocol/wave/client/editor/impl/AutoLinker.java > <https://reviews.apache.org/r/3294/#comment9391> > > The variable is not used. > > > > /src/org/waveprotocol/wave/client/editor/impl/AutoLinker.java > <https://reviews.apache.org/r/3294/#comment9395> > > Need space before and after operator, i.e. > i=0 -> i = 0 > i<text.length-1 -> i < text.length -1 > And also below. > > > > /src/org/waveprotocol/wave/client/editor/impl/AutoLinker.java > <https://reviews.apache.org/r/3294/#comment9392> > > Can we extract the scheme extraction logic into a separate method? > > > > /src/org/waveprotocol/wave/client/editor/impl/AutoLinker.java > <https://reviews.apache.org/r/3294/#comment9393> > > Can we move the declaration of "offset" to a new line? > > > > /src/org/waveprotocol/wave/client/editor/impl/AutoLinker.java > <https://reviews.apache.org/r/3294/#comment9389> > > Can we move this testStr calculation out of the inner for? > > > > /src/org/waveprotocol/wave/client/editor/impl/AutoLinker.java > <https://reviews.apache.org/r/3294/#comment9390> > > Is it safe to use here the "==" operator instead of equals() method? > > > - Yuri > > > On 2011-12-23 23:01:27, Ali Lown wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/3294/ >> ----------------------------------------------------------- >> >> (Updated 2011-12-23 23:01:27) >> >> >> Review request for wave and Yuri Zelikov. >> >> >> Summary >> ------- >> >> Implements an auto-linker feature as requested. >> >> This implementation works by splitting the data by the uri seperator "://" >> and then attempting to match the scheme to a known (currently hard-coded >> list) of schemes. The end is detected by either a space or EOL. >> >> This implementation allows any character to be before a valid scheme, but >> relies upon a space or EOL to find the end. >> >> >> This addresses bug WAVE-275. >> https://issues.apache.org/jira/browse/WAVE-275 >> >> >> Diffs >> ----- >> >> /src/org/waveprotocol/wave/client/editor/impl/AutoLinker.java PRE-CREATION >> /src/org/waveprotocol/wave/client/StageThree.java 1213039 >> /src/org/waveprotocol/wave/client/common/safehtml/EscapeUtils.java 1213039 >> /src/org/waveprotocol/wave/client/doodad/link/Link.java 1213039 >> >> Diff: https://reviews.apache.org/r/3294/diff >> >> >> Testing >> ------- >> >> Tested manually by running the server and typing in URLs in various forms, >> as well as by copy-pasting in. >> >> >> Thanks, >> >> Ali >> >> >
