----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3771/#review4855 -----------------------------------------------------------
./src/org/waveprotocol/box/server/waveserver/DeltaStoreBasedWaveletState.java <https://reviews.apache.org/r/3771/#comment10663> Let's use ArrayList here as it is cheaper. ./src/org/waveprotocol/box/server/waveserver/DeltaStoreBasedWaveletState.java <https://reviews.apache.org/r/3771/#comment10742> Can we allow the caller class decide when it wants to flush the deltas? Similar to what it is now? Maybe by making the task to return the list of versions that can be safely removed instead of Void? - Yuri On 2012-02-07 11:13:34, Andrew Kaplanov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3771/ > ----------------------------------------------------------- > > (Updated 2012-02-07 11:13:34) > > > Review request for wave and Yuri Zelikov. > > > Summary > ------- > > See https://issues.apache.org/jira/browse/WAVE-328. > > > Diffs > ----- > > > ./src/org/waveprotocol/box/server/waveserver/DeltaStoreBasedWaveletState.java > 1241392 > ./src/org/waveprotocol/box/server/waveserver/WaveletContainerImpl.java > 1241392 > > Diff: https://reviews.apache.org/r/3771/diff > > > Testing > ------- > > > Thanks, > > Andrew > >
