> On 2012-02-02 08:46:23, Yuri Zelikov wrote: > > /src/org/waveprotocol/wave/client/wavepanel/impl/focus/FocusFramePresenter.java, > > line 208 > > <https://reviews.apache.org/r/3729/diff/1/?file=71720#file71720line208> > > > > Another possibility is to return back to the root blip and use > > focus(next). I think that such cyclic behavior is more natural. But I am > > not sure. Worth asking the community opinion on the mailing list. > > Yuri Zelikov wrote: > Maybe this way is more convenient. I think we can try it and change in > case of feedback. LGTM
Committed as r1241658 - Yuri ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3729/#review4765 ----------------------------------------------------------- On 2012-02-01 22:18:20, Ali Lown wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3729/ > ----------------------------------------------------------- > > (Updated 2012-02-01 22:18:20) > > > Review request for wave and Yuri Zelikov. > > > Summary > ------- > > After feedback from users pressing 'space' or clicking the 'next unread' > button, they wondered why it only went down the wave when pressed. > The 'shift-space' option was never found by exploration (since not exactly > clear), and the absence of a 'previous unread' button made it appear to > simply be broken instead. > > This patch makes calls to focusNext (called by both the 'space' key handler, > and the 'Next Unread' button) try considering unread blips that are 'above' > their current location in the wave in an order such that they move back up > the wave. > > > Diffs > ----- > > > /src/org/waveprotocol/wave/client/wavepanel/impl/focus/FocusFramePresenter.java > 1237143 > > Diff: https://reviews.apache.org/r/3729/diff > > > Testing > ------- > > Applied and set up a wave where by the user focus was near the bottom. After > inserting an indented reply above it, and pressing 'space' or 'next unread' > the focus moved upwards to it as expected. > > > Thanks, > > Ali > >
