> On 2012-04-18 14:37:49, Michael MacFadden wrote:
> > Do all of the changes in this patch have to do with this exception?  It 
> > seems like some of the them are unrelated.

I think all the changes are related to the same issue.


- Yuri


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4769/#review7003
-----------------------------------------------------------


On 2012-04-18 06:39:48, Yuri Zelikov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4769/
> -----------------------------------------------------------
> 
> (Updated 2012-04-18 06:39:48)
> 
> 
> Review request for wave, Michael MacFadden and Christian Ohler.
> 
> 
> Summary
> -------
> 
> Avoid crash due to IAE in link annotation converter - adopted from patch to 
> Walkaround by Christian Ohler 
> http://code.google.com/p/walkaround/source/detail?r=a7ce6506637f8d50024f144acd2f049a6c769923
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/wave/client/wavepanel/view/dom/FullStructure.java 
> daa3810 
>   
> src/org/waveprotocol/wave/client/wavepanel/view/dom/ParticipantAvatarDomImpl.java
>  f0c47d9 
>   src/org/waveprotocol/wave/migration/helpers/FixLinkAnnotationsFilter.java 
> f824113 
>   src/org/waveprotocol/wave/model/waveref/InvalidWaveRefException.java 
> ef83673 
>   src/org/waveprotocol/wave/model/waveref/WaverefEncoder.java 9c69bcc 
>   test/org/waveprotocol/wave/model/waveref/WaverefEncoderTest.java ad724d8 
>   src/org/waveprotocol/wave/client/wavepanel/impl/edit/KeepFocusInView.java 
> 6aa4c2f 
> 
> Diff: https://reviews.apache.org/r/4769/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yuri
> 
>

Reply via email to