----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4836/#review7113 -----------------------------------------------------------
Ship it! LGTM. - Ali On 2012-04-21 18:23:27, Yuri Zelikov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4836/ > ----------------------------------------------------------- > > (Updated 2012-04-21 18:23:27) > > > Review request for wave, Michael MacFadden and Ali Lown. > > > Summary > ------- > > Updates GravatarProfilesFetcher to use HTTPS only if needed. This avoids of > using HTTPS images URLs which are not cached by the browser even when running > in non secure mode. > > > Diffs > ----- > > > src/org/waveprotocol/box/server/robots/active/ActiveApiOperationServiceRegistry.java > 16936bb > > src/org/waveprotocol/box/server/robots/dataapi/DataApiOperationServiceRegistry.java > b2b5b11 > src/org/waveprotocol/box/server/robots/operations/FetchProfilesService.java > eae40c2 > > src/org/waveprotocol/box/server/robots/operations/GravatarProfilesFetcher.java > 794614b > src/org/waveprotocol/box/server/robots/RobotApiModule.java 8b7b16a > > Diff: https://reviews.apache.org/r/4836/diff > > > Testing > ------- > > Tested locally. Tests pass. > > > Thanks, > > Yuri > >
