> On 2012-05-01 16:13:22, Ali Lown wrote: > > LGTM. > > > > Should images be stored on the local wave server rather than needing the > > client to fetch them from a remote url?
I think fetching them from the location provided by the gadget author is simpler. Also it allows the gadget author to update the image at his discretion. - Yuri ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4948/#review7424 ----------------------------------------------------------- On 2012-05-01 13:53:17, Yuri Zelikov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4948/ > ----------------------------------------------------------- > > (Updated 2012-05-01 13:53:17) > > > Review request for wave, Michael MacFadden, Ali Lown, and Lennard de Rijk. > > > Summary > ------- > > Adds image URLs to the gadget definitions + adds two more gadgets. > On behalf of Jeremy - > http://www.mail-archive.com/[email protected]/msg02736.html > > > Diffs > ----- > > jsongadgets.json f512ceb > > Diff: https://reviews.apache.org/r/4948/diff > > > Testing > ------- > > Tested locally. > > > Thanks, > > Yuri > >
