----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5018/ -----------------------------------------------------------
(Updated 2012-05-05 14:23:35.458265) Review request for wave, Michael MacFadden, vjrj, and Ali Lown. Changes ------- Adds announcement html to the patch. The announcement html is displayed on the top bar - if not empty. Summary ------- Adds GXP template for generation Google Analytics snippet and hooks it into all pages. This idea was also adopted from Walkaround. Diffs (updated) ----- server-config.xml 1dd74af server.config.example 50f80c4 src/org/waveprotocol/box/server/CoreSettings.java 56c6c4a src/org/waveprotocol/box/server/gxp/AnalyticsFragment.gxp PRE-CREATION src/org/waveprotocol/box/server/gxp/AuthenticationPage.gxp 5fecf68 src/org/waveprotocol/box/server/gxp/RobotRegistrationPage.gxp PRE-CREATION src/org/waveprotocol/box/server/gxp/RobotRegistrationSuccessPage.gxp PRE-CREATION src/org/waveprotocol/box/server/gxp/TopBar.gxp a7a53ff src/org/waveprotocol/box/server/gxp/UserRegistrationPage.gxp 475d1c7 src/org/waveprotocol/box/server/gxp/WaveClientPage.gxp a759e67 src/org/waveprotocol/box/server/gxp/robots/RobotRegistrationPage.gxp bab4ff7 src/org/waveprotocol/box/server/gxp/robots/RobotRegistrationSuccessPage.gxp c114bd3 src/org/waveprotocol/box/server/robots/RobotRegistrationServlet.java d0e6f33 src/org/waveprotocol/box/server/rpc/AuthenticationServlet.java c5ad261 src/org/waveprotocol/box/server/rpc/UserRegistrationServlet.java 3e0fc9d src/org/waveprotocol/box/server/rpc/WaveClientServlet.java 3b557a1 test/org/waveprotocol/box/server/rpc/AuthenticationServletTest.java 1232315 test/org/waveprotocol/box/server/rpc/UserRegistrationServletTest.java 8b91e7b Diff: https://reviews.apache.org/r/5018/diff Testing ------- Tested locally - everything compiles and the analytics snippet is generated and added to all pages if defined in server.config. Thanks, Yuri
