> On 2012-05-07 13:36:08, Michael MacFadden wrote: > > Looks pretty good. Once question. Why two key combos for the same action. > > ctrl+k and ctrl+shift+k. Why would a user use the version with shift?
Nevermind. I missed the fact that the shift is clearing the link. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5048/#review7631 ----------------------------------------------------------- On 2012-05-06 23:34:33, vjrj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5048/ > ----------------------------------------------------------- > > (Updated 2012-05-06 23:34:33) > > > Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown. > > > Summary > ------- > > This patch adds two new shortcuts (Ctrl+K, Ctrl+Shift+K) to the wave Editor > to create/remove links after some link text selection (to avoid the use of > the mouse). > > This is similar to Google Docs shortcut for link creation. > > > Diffs > ----- > > src/org/waveprotocol/wave/client/common/util/EventWrapper.java a6ea974 > src/org/waveprotocol/wave/client/common/util/KeyCombo.java 43df6c9 > src/org/waveprotocol/wave/client/wavepanel/impl/edit/EditSession.java > b4f141b > src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/EditToolbar.java > eb8402c > src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/LinkerHelper.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/5048/diff > > > Testing > ------- > > Tested in ff and in chrome. > > > Thanks, > > vjrj > >
