> On 2012-05-08 17:58:40, vjrj wrote: > > Now works great, but still exist some errors in the console (but are not > > related). Can be fixed with excludes in gwt.xml files, like: > > > > diff --git a/src/org/waveprotocol/wave/model/Model.gwt.xml > > b/src/org/waveprotocol/wave/model/Model.gwt.xml > > index cb25ecf..83bbcee 100644 > > --- a/src/org/waveprotocol/wave/model/Model.gwt.xml > > +++ b/src/org/waveprotocol/wave/model/Model.gwt.xml > > @@ -58,6 +58,8 @@ > > <source path="schema"/> > > > > <source path="version"/> > > + > > + <source path="testing" > > excludes="**/*Test*.java,**/*Tests*.java,**/*ExtraAsserts.java, > > **/*OpMatchers.java, **/*Response.java" /> > > > > <source path="undo"/> > > > > New review or can we fix it, in this same review?
I guess it would be better if you could submit a new patch. Thanks! - Yuri ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5068/#review7689 ----------------------------------------------------------- On 2012-05-08 17:29:21, Yuri Zelikov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5068/ > ----------------------------------------------------------- > > (Updated 2012-05-08 17:29:21) > > > Review request for wave, Michael MacFadden, vjrj, and Ali Lown. > > > Summary > ------- > > Fixes Waveharness - issue WAVE-346 > > > This addresses bug WAVE-346. > https://issues.apache.org/jira/browse/WAVE-346 > > > Diffs > ----- > > src/org/waveprotocol/box/webclient/client/StageTwoProvider.java 22557cf > src/org/waveprotocol/box/webclient/client/StagesProvider.java 82e289b > src/org/waveprotocol/box/webclient/client/WindowTitleHandler.java > PRE-CREATION > src/org/waveprotocol/wave/client/StageTwo.java d9ac106 > > src/org/waveprotocol/wave/client/wavepanel/impl/title/WindowTitleHandler.java > 43e0553 > > Diff: https://reviews.apache.org/r/5068/diff > > > Testing > ------- > > Tested locally - WIAB and Waveharness compile/run. > > > Thanks, > > Yuri > >
