----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5118/#review7899 -----------------------------------------------------------
Ship it! LGTM besides minor issue with '"' that I already fixed. jsongadgets.json <https://reviews.apache.org/r/5118/#comment17211> The json format doesn't allow '"' inside strings and requires to escape them with '\', i.e. "no" -> \"no\". You can use JSON validation tools like http://jsonlint.com/ to make sure the JSON is valid. - Yuri On 2012-05-15 15:57:09, Jeremy Naegel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5118/ > ----------------------------------------------------------- > > (Updated 2012-05-15 15:57:09) > > > Review request for wave, Yuri Zelikov, Ali Lown, and rocklund. > > > Summary > ------- > > Updates gadgets list with 8 compatible gadgets, most coming from the Google > Wave APIs Samples Gallery. > + replaces the thumbnail of the Yes/No/Mini gadget by the 'official' one > (from the gadget's installer XML). > > > Diffs > ----- > > jsongadgets.json a0203f2 > > Diff: https://reviews.apache.org/r/5118/diff > > > Testing > ------- > > All the added gadgets were tested on the http://waveinabox.net demo server > and do work. > > > Thanks, > > Jeremy > >
