----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5180/#review8058 -----------------------------------------------------------
Ship it! LGTM Committed as r1341965. - Yuri On 2012-05-21 18:21:35, vjrj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5180/ > ----------------------------------------------------------- > > (Updated 2012-05-21 18:21:35) > > > Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown. > > > Summary > ------- > > With this patch blip menu items reacts to mouse clicks instead of mouse down > events (similar behaviour than the toolbar buttons). > > (This feedback comes from a usability expert) > > > Diffs > ----- > > src/org/waveprotocol/wave/client/wavepanel/impl/menu/MenuController.java > 99b8fac > > Diff: https://reviews.apache.org/r/5180/diff > > > Testing > ------- > > Some tests with "ant waveharness-hosted" > > > Thanks, > > vjrj > >
