Sure. You are welcome to open an issue for this in JIra. On Wed, May 30, 2012 at 1:48 AM, Paulo Pires <[email protected]> wrote:
> The implementation of websocket client used in WIAB is kinda deprecated > as it only supports draft-hyxie-75. Should we look forward to implement > support, both on server and client-side, for RFC6455? > > See http://en.wikipedia.org/wiki/WebSocket#Browser_support_2 > http://en.wikipedia.org/wiki/Comparison_of_WebSocket_implementations > > PP > > On 29/05/12 18:22, Yuri Zelikov wrote: > > > >> On 2012-05-29 14:21:21, Michael MacFadden wrote: > >>> The patch itself looks fine to me. However I would like some one else > to weigh in on if we still ened this option at all. > > I think it's useless since we always prefer websockets, but if it is not > available - I see no reason why not to try Socket.IO. > > > > > > - Yuri > > > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/5258/#review8164 > > ----------------------------------------------------------- > > > > > > On 2012-05-29 11:47:53, Vicente J. Ruiz Jurado wrote: > >> ----------------------------------------------------------- > >> This is an automatically generated e-mail. To reply, visit: > >> https://reviews.apache.org/r/5258/ > >> ----------------------------------------------------------- > >> > >> (Updated 2012-05-29 11:47:53) > >> > >> > >> Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown. > >> > >> > >> Summary > >> ------- > >> > >> The server configuration parameter useSocketIO is not used now (in the > past this parameter was forcing the use of socketio). Currently > WebClient.java try to use socketio only if websocket is not available: > >> > >> private native boolean useSocketIO() /*-{ return !window.WebSocket }-*/; > >> > >> In the server socketio servlet and websocket servlet are available at > the same time. > >> > >> I think is better to remove this parameter because we pass it to the > client but we are not using it. > >> > >> > >> Diffs > >> ----- > >> > >> server-config.xml ddfc669 > >> server.config.example cf8aeb1 > >> src/org/waveprotocol/box/server/CoreSettings.java 3df1eae > >> src/org/waveprotocol/box/server/gxp/WaveClientPage.gxp 294212c > >> src/org/waveprotocol/box/server/rpc/WaveClientServlet.java 921979b > >> > >> Diff: https://reviews.apache.org/r/5258/diff > >> > >> > >> Testing > >> ------- > >> > >> ant dist-server && ./run-server.sh > >> > >> > >> Thanks, > >> > >> Vicente J. > >> > >> > > > > -- > Paulo Pires > >
