----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5327/#review8295 -----------------------------------------------------------
Ship it! I don't see a lot to review here so LGTM. Though perhaps the methods waveFrame.setTitle (as in html element attribute) and waveFrame.setTitleText (for the frame header) and Window.setTitle (as in html tag) are too similarly named? - Ali On 2012-06-01 12:43:49, Yuri Zelikov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5327/ > ----------------------------------------------------------- > > (Updated 2012-06-01 12:43:49) > > > Review request for wave, Michael MacFadden, Vicente J. Ruiz Jurado, and Ali > Lown. > > > Summary > ------- > > Fixes the issue with wave title tool tip showing inside wave body > > > Diffs > ----- > > src/org/waveprotocol/box/webclient/client/WindowTitleHandler.java f261bdf > > Diff: https://reviews.apache.org/r/5327/diff > > > Testing > ------- > > Compiled and checked locally. > > > Thanks, > > Yuri > >
