Paulo (and Michael) This looks great. It is another step closer to making the server and client completely separate projects (which is what I feel we should be aiming for here).
Ali On 6 June 2012 22:12, Paulo Pires <[email protected]> wrote: > Me & Michael are happy to announce that we've reached a very important > milestone in getting WIAB to compile with Maven. > > https://github.com/pires/wave/commit/b3229d6790d40d1a894eba2c6f7a94e304767614 > > And it works! > > For the next milestone (M2), we'll be simplifying the project structure > and make modules separation more straightforward, polishing build > process and eventually adding some goodies. > > Would be nice to have everyone's feedback on this :-) > > Cheers, > PP > > On Sun Jun 3 15:03:59 2012, Michael MacFadden wrote: >> Paulo, >> >> I'll have to get on GitHub or something. All, I did was to pull down your >> code and start editing it locally. I haven't published it anywhere. I will >> do that. >> >> In the mean time, I think you have misunderstood the problem. The problem >> is not that the GWT files are not getting added to the box jar. They were >> getting added to the jar. The issue is that the GWT files are not supposed >> to be in the jar, they are expected to be in a directory on the filesystem >> called "war" (or whatever is specified in the config file). So until we >> re-architect the code, adding it to the jar file won't actually help. Plus >> as you say I don't think the GWT files should actually live in the server >> project jar anyway. >> >> I have gotten around this by generating the GWT file in a separate maven >> submodule, and then unpacking them when they are needed. I think now I am >> just having a class path issue. i will get the code published somewhere >> today. >> >> ~Michael >> >> On Jun 3, 2012, at 5:54 AM, Paulo Pires wrote: >> >>> The maven-shade-plugin does the actual assembly of the box module. As >>> long as the GWT module, if any, is a dependency of box module, it should >>> be part of the final JAR file. >>> >>> Once again I ask you for access to your current working repo. >>> >>> PP >>> >>> On 03/06/12 05:13, Michael MacFadden wrote: >>>> Paulo, >>>> >>>> I actually have the GWT compiling and an assembly built in maven that >>>> pulls everything together. I am still getting that exception. The >>>> question I have is how are you running the server. The shell script has: >>>> >>>> #!/bin/bash >>>> >>>> # This script will start the Wave in a Box server. >>>> # >>>> >>>> # Make sure the config file exists. >>>> if [ ! -e server.config ]; then >>>> echo "You need to copy server.config.example to server.config and edit >>>> it. Or run: 'ant -f server-config.xml' to generate the file automatically." >>>> exit 1 >>>> fi >>>> >>>> . process-script-args.sh >>>> >>>> exec java $DEBUG_FLAGS \ >>>> -Dorg.eclipse.jetty.LEVEL=DEBUG \ >>>> -Djava.security.auth.login.config=jaas.config \ >>>> -Dwave.server.config=server.config \ >>>> -jar box/target/box-0.3-SNAPSHOT.jar >>>> >>>> >>>> >>>> This doesn't seem to add any of the other required jars to the classpath. >>>> >>>> ~Michael >>>> >>>> On May 30, 2012, at 9:17 AM, Paulo Pires wrote: >>>> >>>>> Well, I had issues when I was using protoc 2.3.0 with >>>>> protobuf-java-2.4.1. Since I've upgraded the protobuf-java dependency >>>>> to version 2.4.1, one must have protoc 2.4.1 as well. Or so I read >>>>> somewhere over at the project mailing-lists. >>>>> >>>>> On Wed May 30 17:13:32 2012, Michael MacFadden wrote: >>>>>> No worries, I just wanted to make sure you knew that I wasn't starting >>>>>> from scratch. I am sure it is something on my end. I had installed >>>>>> protobuf a long time agoŠmanually, from source, not using brew. So, I am >>>>>> re-installing it just to make sure that is not the issue. >>>>>> >>>>>> ~Micheal >>>>>> >>>>>> On 5/30/12 9:10 AM, "Paulo Pires" <[email protected]> wrote: >>>>>> >>>>>>> Michael, >>>>>>> >>>>>>> I hope you don't think that I'm underestimating your abilities! That's >>>>>>> in no way whatsoever what I meant. >>>>>>> >>>>>>> The thing is that current mainstream WIAB doesn't compile the proto >>>>>>> files but instead had it compiled once and persisted the resulting Java >>>>>>> classes in SVN, am I right? And that's why I pointed you the poor >>>>>>> documentation provided, as I've changed this behavior and couldn't be >>>>>>> sure if you've overlooked it or not. >>>>>>> >>>>>>> Anyway, I'm eager to get your changes! >>>>>>> >>>>>>> Good luck, >>>>>>> PP >>>>>>> >>>>>>> On Wed May 30 16:55:11 2012, Michael MacFadden wrote: >>>>>>>> Paulo, >>>>>>>> >>>>>>>> For some context. I am one of the Apache Wave project committers and >>>>>>>> PMC members. I have been working on wave for several years now >>>>>>>> (although I have been coding a bit less). So, I do have protoc >>>>>>>> installed and can currently build wiab. I suspect there is just some >>>>>>>> differences in the default settings. For example, the location of your >>>>>>>> protoc install is not the same as mine. There could be some other >>>>>>>> issues like that. I will chase them down. >>>>>>>> >>>>>>>> >>>>>>>> On May 30, 2012, at 8:47 AM, Paulo Pires wrote: >>>>>>>> >>>>>>>>> Have you got protobuf-compiler installed? See README.md and >>>>>>>>> build-proto.properties for instructions. >>>>>>>>> >>>>>>>>> Anyway, I've tested this with a clean Lion (no Maven cache and a new >>>>>>>>> clone) and it worked. Also, I had the same result with a clean Linux >>>>>>>>> Mint 13 installed. >>>>>>>>> >>>>>>>>> On Wed May 30 16:44:29 2012, Michael MacFadden wrote: >>>>>>>>>> OSX. I almost have it building right now it is not generating the >>>>>>>>>> protobuf messages. (what used to go into gen/messages in the old >>>>>>>>>> project). So for example: >>>>>>>>>> >>>>>>>>>> import >>>>>>>>>> org.waveprotocol.box.common.comms.proto.DocumentSnapshotProtoImpl; >>>>>>>>>> >>>>>>>>>> Is not being generated. I think this is the last step. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On May 30, 2012, at 8:32 AM, Paulo Pires wrote: >>>>>>>>>> >>>>>>>>>>> Which OS are you running? >>>>>>>>>>> >>>>>>>>>>> PP >>>>>>>>>>> >>>>>>>>>>> On Wed May 30 15:59:31 2012, Michael MacFadden wrote: >>>>>>>>>>>> Paulo, >>>>>>>>>>>> >>>>>>>>>>>> This worked but only after I change the line in the pom where the >>>>>>>>>>>> local repo is defined. I changed it from: >>>>>>>>>>>> >>>>>>>>>>>> <url>file:///${basedir}/../repo/</url> >>>>>>>>>>>> >>>>>>>>>>>> to >>>>>>>>>>>> >>>>>>>>>>>> <url>file://${basedir}/../repo/</url> >>>>>>>>>>>> >>>>>>>>>>>> On May 30, 2012, at 5:48 AM, Paulo Pires wrote: >>>>>>>>>>>> >>>>>>>>>>>>> My bad! It's now fixed in >>>>>>>>>>>>> >>>>>>>>>>>>> https://github.com/pires/wave/commit/8f016c455345a1210ad195f01414c02 >>>>>>>>>>>>> e2227273a >>>>>>>>>>>>> >>>>>>>>>>>>> Please, confirm this change fixes the issue you're facing. >>>>>>>>>>>>> >>>>>>>>>>>>> PP >>>>>>>>>>>>> >>>>>>>>>>>>> On 30/05/12 05:13, Michael MacFadden wrote: >>>>>>>>>>>>>> Paulo, >>>>>>>>>>>>>> >>>>>>>>>>>>>> Did you perhaps add several jars to you local maven repository? >>>>>>>>>>>>>> When I try to compile the project, I get several dependencies >>>>>>>>>>>>>> that >>>>>>>>>>>>>> done resolve. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Missing artifact net.oauth:consumer:jar:20100601 >>>>>>>>>>>>>> Missing artifact net.oauth:provider:jar:20100601 >>>>>>>>>>>>>> ... >>>>>>>>>>>>>> Missing artifact >>>>>>>>>>>>>> com.glines.socketio:socketio-core:jar:0.1-SNAPSHOT >>>>>>>>>>>>>> >>>>>>>>>>>>>> And some others. >>>>>>>>>>>>>> >>>>>>>>>>>>>> ~Michael >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> On May 29, 2012, at 5:18 PM, Paulo Pires wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>>> That's great, Michael! >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Since the project is now split in modules, I believe that we >>>>>>>>>>>>>>> should >>>>>>>>>>>>>>> follow section 15 of >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> http://mojo.codehaus.org/gwt-maven-plugin/pdf/gwt-maven-plugin.pdf >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Eventually, we can even extract 'webclient' stuff from 'box' >>>>>>>>>>>>>>> module to >>>>>>>>>>>>>>> a new one. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> PP >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> On Wed May 30 00:57:29 2012, Michael MacFadden wrote: >>>>>>>>>>>>>>>> I am working on the gwt maven plugin now >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> -Michael. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> On May 29, 2012, at 4:34 PM, Paulo Pires <[email protected]> >>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> I only need to get GWT compiled to JS and then I think I'll be >>>>>>>>>>>>>>>>> able to >>>>>>>>>>>>>>>>> use it fully. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> On Tue May 29 23:18:47 2012, Paulo Pires wrote: >>>>>>>>>>>>>>>>>> Hi all, >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> I've got to a state where I can run WIAB and register/log a >>>>>>>>>>>>>>>>>> user. Anyone >>>>>>>>>>>>>>>>>> willing to give it a try and report issues at >>>>>>>>>>>>>>>>>> https://github.com/pires/wave/issues/5 ? >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> When we reach a WIAB fully running instance with this fork, >>>>>>>>>>>>>>>>>> I'll get >>>>>>>>>>>>>>>>>> back to a proper upstream fix for WAVE-294. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Cheers, >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>>> Paulo Pires >>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>> Paulo Pires >>>>>>>>>>>>> -- >>>>>>>>>>>>> Paulo Pires >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> Paulo Pires >>>>>>>>>> >>>>>>>>> -- >>>>>>>>> Paulo Pires >>>>>>> -- >>>>>>> Paulo Pires >>>>>> >>>>> -- >>>>> Paulo Pires >>>> >>> >>> -- >>> Paulo Pires >>> >> > > -- > Paulo Pires
