----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6340/#review10029 -----------------------------------------------------------
Ship it! LGTM. Committed as r1370894. - Yuri Zelikov On Aug. 3, 2012, 12:58 p.m., Vicente J. Ruiz Jurado wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6340/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2012, 12:58 p.m.) > > > Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown. > > > Description > ------- > > Hi, by default the width of the gadgets are 600px if the gadget has not set > its width. This is quite arbitrary, IMHO, and gives many problems of > rendering, offsets, etc. > > This patch sets the default with to 100% also allow the use of percentages in > gadget widths. > > > This addresses bug WAVE-309. > https://issues.apache.org/jira/browse/WAVE-309 > > > Diffs > ----- > > src/org/waveprotocol/wave/client/gadget/renderer/Gadget.css ba87cf7 > src/org/waveprotocol/wave/client/gadget/renderer/GadgetWidget.java 1e38273 > > Diff: https://reviews.apache.org/r/6340/diff/ > > > Testing > ------- > > Tested with gadgets that sets the width (like Yes/No/Maybe) and others that > do not set it (the maps, for instance). In thouse, the width should occupy > the 100% of the editor, even if you use the split scroll. > > Tested also in production. > > > Thanks, > > Vicente J. Ruiz Jurado > >
