----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7903/#review13286 -----------------------------------------------------------
Ship it! Ship It! src/org/waveprotocol/box/server/util/RegistrationUtil.java <https://reviews.apache.org/r/7903/#comment28546> Check -> Checks - Yuri Zelikov On Nov. 6, 2012, 8:11 p.m., Vicente J. Ruiz Jurado wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7903/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2012, 8:11 p.m.) > > > Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown. > > > Description > ------- > > Minor review: This patch creates a new method in RegistrationUtil that makes > possible to reuse this portion of the code. > > > Diffs > ----- > > src/org/waveprotocol/box/server/rpc/UserRegistrationServlet.java 17359bb > src/org/waveprotocol/box/server/util/RegistrationUtil.java 52e0626 > > Diff: https://reviews.apache.org/r/7903/diff/ > > > Testing > ------- > > Some registrations tests (with correct and incorrect usernames). > > > Thanks, > > Vicente J. Ruiz Jurado > >
