----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20371/#review46941 -----------------------------------------------------------
Sorry, it took so long to review it. Great patch! The only thing is that it seems like the changes to server.config and server-config.xml are missing. - Yuri Zelikov On April 15, 2014, 5:17 p.m., Pablo Ojanguren wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20371/ > ----------------------------------------------------------- > > (Updated April 15, 2014, 5:17 p.m.) > > > Review request for wave, Ali Lown, Vicente J. Ruiz Jurado, and Yuri Zelikov. > > > Bugs: WAVE-412 > https://issues.apache.org/jira/browse/WAVE-412 > > > Repository: wave > > > Description > ------- > > Support to live installations of Wave (and its flavors) is needed if they > decide move from file to mongodb storage for deltas. So this is a tool to > move data from stores. > > Additionally, MongoDB configuration has been moved from the separated > property file (src/org/waveprotocol/box/server/persistence/mongodb) to the > server.config file. If no property is set, default values are taken. See > CoreSettings.java for more info. > > > Diffs > ----- > > run-data-migration.sh PRE-CREATION > src/org/waveprotocol/box/server/CoreSettings.java > 0a6f3fd50941a112acc50031c1220f3beb1dbca9 > src/org/waveprotocol/box/server/DataMigrationTool.java PRE-CREATION > src/org/waveprotocol/box/server/persistence/PersistenceModule.java > 14c645365604d75703dea781ad159132fcd3b45f > src/org/waveprotocol/box/server/persistence/migration/DeltaMigrator.java > PRE-CREATION > src/org/waveprotocol/box/server/persistence/mongodb/MongoDbProvider.java > 4e290779444ac6d2a28e4573eef7fa0dd3895105 > test/org/waveprotocol/box/server/persistence/mongodb/AccountStoreTest.java > df79f791e7462c233af0edecd86d01457dbd6227 > > test/org/waveprotocol/box/server/persistence/mongodb/AttachmentStoreTest.java > 46dd70b8aab90d90baa91c9643cbb4586051dc65 > test/org/waveprotocol/box/server/persistence/mongodb/CertPathStoreTest.java > 62bcd74478269983a639ce50121da7703f38c336 > > Diff: https://reviews.apache.org/r/20371/diff/ > > > Testing > ------- > > Basic manual test: all waves (12) in a local server initially stored in file > where migrated succesfully. > > > Thanks, > > Pablo Ojanguren > >
