----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25022/#review79827 -----------------------------------------------------------
Ship it! LGTM Thanks! - Yuri Zelikov On Aug. 25, 2014, 12:13 p.m., Antonio Tenorio-Fornés wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25022/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2014, 12:13 p.m.) > > > Review request for wave and Pablo Ojanguren. > > > Bugs: WAVE-417 > https://issues.apache.org/jira/browse/WAVE-417 > > > Repository: wave > > > Description > ------- > > When the state of a gadget changes, the EventGenerator generates a > GadgetStateChange event so robots can subscribe to this kind of events. > > > Diffs > ----- > > src/org/waveprotocol/box/server/robots/passive/EventGenerator.java > be70f0b0c627c371b7c556146b35be59df53c1a2 > > Diff: https://reviews.apache.org/r/25022/diff/ > > > Testing > ------- > > - Add a gadget in a wave conversation. > - Invite a robot to the conversation which logs GadgetStateChanged events > (previously registered). https://gitorious.org/p2pvalue/waverobotbasicsample > - Do actions that change gadget's state. > - Verify that the robot has logged the expected state changes. > > > Thanks, > > Antonio Tenorio-Fornés > >
