Thanks for the comments Ali. 1 - This one is nasty, forgot to remove the logs... We need to fix the release script to ignore logs... 2. Right, but this one is minor I think. 3. So, what would be a better name for folder? 0.4.0-RC8? Regarding artifact name - I think "incubating" is actually part of the project name, not part of the version. The "alpha" was added following suggestions in the mail list. Well, I can create a new RC addressing the comments above - it's matter of minutes (besides uploading it to apache site which takes hours with my connection). Should we go for this?
On Wed, Apr 15, 2015 at 4:37 PM Ali Lown <a...@lown.me.uk> wrote: > -0 > > Checked signatures, SHA hashes, simple server run with federation > enabled and checked waves still work, checked the CAPS FILES (CHANGES, > DISCLAIMER, KEYS, LICENSE, README.*, THANKS). > > 1) Noticed the source release contains a few wiab-server.log.[01] > files that should not be there... > 2) CHANGES not updated to mention RC7 - even if nothing beyond the > name changed - which is probably more confusing for end users if not > documented. > 3) I agree with Christian that the folder is a bit confusingly named > 0.8, when it really means rc8 for 0.4.0. Similarly for the artifact > which is named "[projname]-incubating-[version]-alpha" rather than the > more conventional "[projname]-[version]-incubating". I also don't > think "alpha" deserves to be in the artifact name. Do we intend to > have a 0.4.0-beta and then a 0.4.0? This seems confusing... > > Sorry, but we should probably have another RC. > > Ali > > On 15 April 2015 at 09:21, Dave Ball <w...@glark.co.uk> wrote: > > +1 > > > > Tested simple local server, sign up, local waves, adding and removing > > recipients. > > > > Dave > > > > > > On 15/04/15 01:08, Ali Lown wrote: > >> > >> Aah. The closing time for this has snuck up on me. I will test this > >> out in the morning. > >> > >> Seems like we could do with a few other people checking it as well > >> though... > >> > >> Ali > >> > >> On 11 April 2015 at 18:25, Yuri Z <vega...@gmail.com> wrote: > >>> > >>> But theactial release won't have the RC8, as it's will be > >>> incubating-0.4.0-alpha > >>> > >>> On Sat, Apr 11, 2015 at 3:04 PM Christian Grobmeier > >>> <grobme...@apache.org> > >>> wrote: > >>> > >>>> I would name it like: > >>>> > >>>> 0.4-incubating-RC8 > >>>> > >>>> I think this is a more convenient pattern. However for this vote I > think > >>>> it's fine. This is more a suggestion for the future. > >>>> however I would pass your information on the naming to the IPMC vote - > >>>> I guess it might confuse people there too. > >>>> > >>>> On Thu, Apr 9, 2015, at 23:31, Yuri Z wrote: > >>>>> > >>>>> It's release candidate 8 for version 0.4.0 alpha. If you think we > >>>>> should > >>>>> name it something else - let me know. > >>>>> > >>>>> On Thu, Apr 9, 2015 at 11:35 PM Christian Grobmeier > >>>>> <grobme...@apache.org> > >>>>> wrote: > >>>>> > >>>>>> +1 > >>>>>> > >>>>>> However, I am still very confused by the link saying it's 0.8 and > the > >>>>>> artifacts saying it's 0.4. > >>>>>> Are we sure this is what we want? It might pass the IPMC also > because > >>>>>> naming the release is not something which can/should be blocked, but > >>>>>> it > >>>>>> might confuse users. > >>>>>> > >>>>>> On Thu, Apr 9, 2015, at 21:49, Yuri Z wrote: > >>>>>>> > >>>>>>> RC8 is now available for review. > >>>>>>> It's basically RC7 with artifact names fixed to include > "incubating" > >>>>>>> Artifacts can be found here: > >>>>>>> > >>>> https://dist.apache.org/repos/dist/dev/incubator/wave/0.8-incubating/ > >>>>>>> > >>>>>>> (Remember checksums are from 'gpg --print-md SHA512 $f > $f.sha') > >>>>>>> > >>>>>>> The release version will be: 0.4.0-alpha > >>>>>>> > >>>>>>> This is taken from branch (same as RC7) > >>>>>>> https://git-wip-us.apache.org/repos/asf?p=incubator-wave. > >>>>>> > >>>>>> git;a=shortlog;h=refs/heads/0.4.0-RC7 > >>>>>>> > >>>>>>> Reminder on what included previous release candidates: > >>>>>>> RC6 included: > >>>>>>> - Bug Fixes > >>>>>>> > >>>>>>> RC5 included: > >>>>>>> - Added MongoDB based deltas store and migration tool for deltas > >>>>>>> migration > >>>>>>> from file to mongo based store. > >>>>>>> > >>>>>>> - Added client/server profiling. > >>>>>>> - Added Atmosphere framework as replacement of Socket.IO. > >>>>>>> - Added alternative - Gmail style initials avatars. > >>>>>>> - Decreased number of permutations in dev compilation and added GWT > >>>>>>> superdev mode. > >>>>>>> - Upgraded the server to Jetty 9.1.1. > >>>>>>> - Added JDK 7 compatibility. > >>>>>>> > >>>>>>> RC4 included: > >>>>>>> - More licensing fixes > >>>>>>> - Federation works > >>>>>>> - New and updated translations > >>>>>>> - And more... > >>>>>>> > >>>>>>> A summary of useful information can be found in RELEASE-NOTES, and > a > >>>> > >>>> list > >>>>>>> > >>>>>>> of changes in CHANGES at the above artifact distribution url, as > >>>> > >>>> well as > >>>>>>> > >>>>>>> being included in the tarballs/zips.(zipballs?) > >>>>>>> > >>>>>>> Action Required: > >>>>>>> Test the release and make it works on your environment - at least > >>>>>>> standard > >>>>>>> configurations. Please go over the source files and make sure they > >>>> > >>>> don't > >>>>>>> > >>>>>>> contain anything that cannot be released under Apache Wave due to > >>>> > >>>> legal > >>>>>>> > >>>>>>> issues. > >>>>>>> > >>>>>>> This vote will close around 0000 GMT 16-th April 2015. > >>>>>>> > >>>>>>> [ ] +1 Release it! > >>>>>>> [ ] +0 OK, but... > >>>>>>> [ ] -0 OK, but you really should fix.... > >>>>>>> [ ] -1 Definitely not because... > >>>>>>> > >>>>>>> Thanks > > > > >
