Hi David, Thanks for the catch! We have always been setting XMPP_SERVER_IP to localhost so never noticed.
There are some issues with submitting code that we are still sorting out, though for the record the reason that the request_codereview command didn't work is that you were missing the -m flag before the "move XMPP..." message. In any case, I've fixed the script, thanks. -- Ben On Wed, Sep 2, 2009 at 7:04 AM, [email protected]<david.c.hubbard%[email protected]> <[email protected]> wrote: > > Hi all, > > There's a bug I found in run-config.sh.example, so I went to submit a > patch: > > $ ./request_codereview --send_mail -e <my email> "move XMPP_SERVER_IP > after XMPP_SERVER_HOSTNAME" -d "In run-config.sh.example: > XMPP_SERVER_IP depends on XMPP_SERVER_HOSTNAME, but > XMPP_SERVER_HOSTNAME is set after it > This just switches the two so that XMPP_SERVER_IP gets the right > value" > No valid patches found in output from hg diff > $ > > But here is the output from hg diff: > > $ hg diff > diff -r a3a65e0eabd2 run-config.sh.example > --- a/run-config.sh.example Sat Aug 29 20:11:52 2009 -0700 > +++ b/run-config.sh.example Tue Sep 01 15:02:37 2009 -0600 > @@ -31,11 +31,11 @@ > PRIVATE_KEY_FILENAME=${WAVE_SERVER_DOMAIN_NAME}.key > CERTIFICATE_FILENAME_LIST=${WAVE_SERVER_DOMAIN_NAME}.cert > > -# Set XMPP_SERVER_IP to localhost if the XMPP and FedOne servers are > -# running on the same host > -XMPP_SERVER_IP=$XMPP_SERVER_HOSTNAME > - > # These should be okay to leave alone > CERTIFICATE_DOMAIN_NAME=$WAVE_SERVER_DOMAIN_NAME > XMPP_SERVER_HOSTNAME=$WAVE_SERVER_DOMAIN_NAME > XMPP_SERVER_PORT=5275 > + > +# Set XMPP_SERVER_IP to localhost if the XMPP and FedOne servers are > +# running on the same host > +XMPP_SERVER_IP=$XMPP_SERVER_HOSTNAME > $ > > I don't know what's up with this, so I'm just going to post a message. > > David > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Wave Protocol" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/wave-protocol?hl=en -~----------~----~----~----~------~----~------~--~---
