While testing annotations (i.e. bold, italic, etc.) with QWaveClient,
I generated the following two deltas.
FedOne should not have accepted these IMHO.
The first delta skips 8 characters and then it marks 3 as bold.
The second delta skips 10 characters and then it marks 4 as bold.
This marks one character as bold twice.
The error in all this is that the "old_value" submitted in the delta
is not correct.
The old_value in the deltas below is null.
But it must be "bold"!
While the deltas are wrong in the first place, the FedOne error is
that it does not check it and happily accepts it.
The problem will become imminent when using playback, i.e. when
undoing the second delta.
SubmitRequest>> wavelet_name: "wave://localhost/w+1741217401/conv
+root"
delta {
hashed_version {
version: 16
history_hash: "K\216\332\263\030\036\334?\303\322\225\371*3v
\361\233\316y\342"
}
author: "tor...@localhost"
operation {
mutate_document {
document_id: "b+b1"
document_operation {
component {
retain_item_count: 8
}
component {
annotation_boundary {
change {
key: "style/fontWeight"
new_value: "bold"
}
}
}
component {
retain_item_count: 3
}
component {
annotation_boundary {
end: "style/fontWeight"
}
}
component {
retain_item_count: 8
}
}
}
}
}
SubmitRequest>> wavelet_name: "wave://localhost/w+1741217401/conv
+root"
delta {
hashed_version {
version: 17
history_hash: "<\217\357B\215\010\017K
\316\202\245\317\323\254\026\362h\007\261\375"
}
author: "tor...@localhost"
operation {
mutate_document {
document_id: "b+b1"
document_operation {
component {
retain_item_count: 10
}
component {
annotation_boundary {
change {
key: "style/fontWeight"
new_value: "bold"
}
}
}
component {
retain_item_count: 4
}
component {
annotation_boundary {
end: "style/fontWeight"
}
}
component {
retain_item_count: 5
}
}
}
}
}
Cheers
Torben
--
You received this message because you are subscribed to the Google Groups "Wave
Protocol" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/wave-protocol?hl=en.
