Hi, I am still trying to figure out the purpose of the commit-notice as it is used within the code as part of the wavelet-update process. I was going back over the spec and it states the commit-notice can be added as part of the wavelet-update message. There is the private method XmppFederationHostForDomain.waveletUpdate() that would allow this, however, there are no public methods available that allow a wavelet- update to be sent to a Federation Remote with the optional commit (the public methods available allow you either to commit or send deltas, but not both). When persistence is added as part of the wavelet- update process, is it the intent to supply the commit-notice as part of the update and remove the separate call in WaveServerImpl.submitDelta()?
Thanks, Anthony On Feb 16, 1:01 pm, Torben Weis <[email protected]> wrote: > Hi, > > thanks for the code walk. This helps explaining which part of the code is > doing this. Let's hope that Google tells us why :-) > > > So my question isn't much different than Torben's. Why are we sending > > a commit-notice and what does that have to do with the fact that we > > don't have persistence yet since the comment in > > fedone.waveserver.WaveServerImpl.submitDelta() says: > > > // TODO: if persistence is added, don't send commit notice > > Perhaps the meaning of the comment is to send the commit notice later (i.e. > after data has been persisted)? Currently the commit notice is sent > automatically without waiting for any commit (just guessing). > > Torben > > > > > Thanks, > > > Anthony -- You received this message because you are subscribed to the Google Groups "Wave Protocol" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/wave-protocol?hl=en.
