There's a couple changes I'd like to make to the fedone websocket
message protocol:
- The JSON currently has inconsistent naming conventions
(sequenceNumber vs participant_id - see below)
- WebSocketChannel.MessageWrapper should embed the message as a JSON
object, not a JSON object encoded inside a string. (The latter is
sloppy to send and use).
Currently messages look like this:
{
"version":0,
"sequenceNumber":1,
"messageType":"waveserver.ProtocolOpenRequest",
"messageJson": "{
\"participant_id\": \"[email protected]\",\"wave_id\":
\"indexwave!indexwave\",\"wavelet_id_prefix\": [\"\"]}"
}
... I'd like to change it to this:
{
"version":0,
"sequence_number":1,
"message_type":"webserver.ProtocolOpenRequest",
"message":
{
"participant_id":"[email protected]",
"wave_id":indexwave!indexwave",
"wavelet_id_prefix":[""]
}
}
Questions:
- Should I just write & submit a patch? Who should I send it to?
- Should I bump the protocol version number for a change like this?
- How many people are effected by changes like this? (Are many people
working on client code using websockets?)
Cheers
Joseph
--
You received this message because you are subscribed to the Google Groups "Wave
Protocol" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/wave-protocol?hl=en.
