On Fri, Jun 11, 2010 at 10:43 PM, Torben Weis <[email protected]> wrote:
>
> If you want to change the italic attribute until the end of the doc, your
> approach would be sufficient.
> BUT: What if you want to change only something in the middle of a document
> and you want to leave the rest of the document as is? Then you need the
> "end" field.
>
Then why don't you set "style/italic"="true" when you want italics to start
and then set "style/italic"=NULL when you want italics to end?
Check out this documentation in the KeyValueUpdate protobuf:
// Absent field means that the attribute should be removed/the
annotation
// should be set to null.
optional string new_value = 3;
Why do we also need the end field when we can just set no new_value (which
does the same thing)?
-J
> Torben
>
>>
>> -J
>>
>>
>> On Fri, Jun 11, 2010 at 10:13 PM, Torben Weis <[email protected]>wrote:
>>
>>> Joseph,
>>>
>>> consider that a delta tells how to transform the document. You can say:
>>> "From here on make it italic". Using "repeated string end" you can say:
>>> "From here on leave the italic attribute as it is".
>>>
>>> The other option you mentioned means: "From here on remove the italic
>>> attribute".
>>>
>>> Two totally different concepts.
>>>
>>> Cheers
>>> Torben
>>>
>>>
>>>
>>> 2010/6/11 Joseph Gentle <[email protected]>
>>>
>>>> In the .proto files annotation boundaries are specified as:
>>>>
>>>> message AnnotationBoundary {
>>>> ...
>>>> repeated string end = 2;
>>>> repeated KeyValueUpdate change = 3;
>>>> }
>>>>
>>>> ... And KeyValueUpdate is:
>>>>
>>>> message KeyValueUpdate {
>>>> required string key = 1;
>>>> // Absent field means that the attribute was absent/the annotation
>>>> // was null.
>>>> optional string old_value = 2;
>>>> // Absent field means that the attribute should be removed/the
>>>> annotation
>>>> // should be set to null.
>>>> optional string new_value = 3;
>>>> }
>>>>
>>>> My question: Why have 'repeated string end' in AnnotationBoundary? Why
>>>> not just use the change field to change the value to null?
>>>>
>>>> ... Or put another way: As an implementor, am I free to use either
>>>> method to null out annotations?
>>>>
>>>> -J
>>>>
>>>> --
>>>> You received this message because you are subscribed to the Google
>>>> Groups "Wave Protocol" group.
>>>> To post to this group, send email to [email protected].
>>>> To unsubscribe from this group, send email to
>>>> [email protected]<wave-protocol%[email protected]>
>>>> .
>>>> For more options, visit this group at
>>>> http://groups.google.com/group/wave-protocol?hl=en.
>>>>
>>>
>>>
>>>
>>> --
>>> ---------------------------
>>> Prof. Torben Weis
>>> Universitaet Duisburg-Essen
>>> [email protected]
>>>
>>> --
>>> You received this message because you are subscribed to the Google Groups
>>> "Wave Protocol" group.
>>> To post to this group, send email to [email protected].
>>> To unsubscribe from this group, send email to
>>> [email protected]<wave-protocol%[email protected]>
>>> .
>>>
>>> For more options, visit this group at
>>> http://groups.google.com/group/wave-protocol?hl=en.
>>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Wave Protocol" group.
>> To post to this group, send email to [email protected].
>> To unsubscribe from this group, send email to
>> [email protected]<wave-protocol%[email protected]>
>> .
>> For more options, visit this group at
>> http://groups.google.com/group/wave-protocol?hl=en.
>>
>
>
>
> --
> ---------------------------
> Prof. Torben Weis
> Universitaet Duisburg-Essen
> [email protected]
>
> --
> You received this message because you are subscribed to the Google Groups
> "Wave Protocol" group.
> To post to this group, send email to [email protected].
> To unsubscribe from this group, send email to
> [email protected]<wave-protocol%[email protected]>
> .
> For more options, visit this group at
> http://groups.google.com/group/wave-protocol?hl=en.
>
--
You received this message because you are subscribed to the Google Groups "Wave
Protocol" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/wave-protocol?hl=en.
