Code review for this is being submitted. On Sat, Oct 9, 2010 at 12:09 AM, Alex North <[email protected]> wrote:
> Soren and I would make good reviewers for large renames. Lennard for ant > files and the like. > > > On 9 October 2010 14:49, Matt Richards <[email protected]> wrote: > >> Yep, are there any particular reviewers I should add when I submit? >> >> >> On Fri, Oct 8, 2010 at 9:57 PM, Alex North <[email protected]> wrote: >> >>> So long as everything stays consistent I suggest making smaller, >>> self-contained changes. So leave the ant file for another patch. >>> >>> >>> On 9 October 2010 12:07, Matt Richards <[email protected]> wrote: >>> >>>> I noticed one was using examples.fedone, I believe. I'm going to take a >>>> new approach to this durring the weekend. Eclipse has a great feature that >>>> assists with renaming things, but I've noticed it misses things so I've >>>> created a real big mess. >>>> >>>> The other question I've got is, should I try to rename >>>> fedone references in ant file, or should I save this work for another >>>> patch? >>>> >>>> On Fri, Oct 8, 2010 at 7:16 PM, Alex North <[email protected]> wrote: >>>> >>>>> Doing it in a few chunks is fine. You're right that the proto_src and >>>>> proto_gwt_src dirs are auto-generated. Do you need to move anything around >>>>> in these packages? >>>>> >>>>> >>>>> On 9 October 2010 01:56, Matt Richards <[email protected]> wrote: >>>>> >>>>>> For the moment I am initally renaming the server, agent, common, >>>>>> consoleclient and webclient packages. >>>>>> >>>>>> There are some package names within proto_src and proto_gwt_src that >>>>>> also need updating, it is my understanding these are automaticly >>>>>> generated >>>>>> using the protoc tool. Though I'm not too fimilar with how this works and >>>>>> I've ran into some snags updating these.. >>>>>> On Mon, Oct 4, 2010 at 11:52 PM, Matt Richards >>>>>> <[email protected]>wrote: >>>>>> >>>>>>> I forgot mercurial isn't like subversion, where it keeps its files in >>>>>>> all your project folders, and moving files around is a huge pain. I >>>>>>> hope to >>>>>>> have something by the end of the week, if not sooner. >>>>>>> >>>>>>> On Mon, Oct 4, 2010 at 10:43 PM, Alex North <[email protected]>wrote: >>>>>>> >>>>>>>> Wonderful. See the mail at the start of the thread for an idea of >>>>>>>> where to move things. I find "hg addremove -s 50" after doing all the >>>>>>>> moves >>>>>>>> seems to pick them all up. >>>>>>>> >>>>>>>> >>>>>>>> On 5 October 2010 14:12, Matt Richards <[email protected]> wrote: >>>>>>>> >>>>>>>>> I'm willing to take a stab at doing so.. >>>>>>>>> But I'm not sure how to track file renames within mercurial and the >>>>>>>>> code review tool. >>>>>>>>> >>>>>>>>> >>>>>>>>> On Fri, Oct 1, 2010 at 12:48 AM, Alex North <[email protected]>wrote: >>>>>>>>> >>>>>>>>>> Well, let's make a change then! >>>>>>>>>> >>>>>>>>>> It looks like there's a strong sentiment to keep the "wave in a >>>>>>>>>> box" idea in the name, so given that I propose we go with >>>>>>>>>> "org.waveprotocol.box" as the top-level package for the server and >>>>>>>>>> clients >>>>>>>>>> we're building into WIAB. This wasn't one of the explicit options >>>>>>>>>> discussed >>>>>>>>>> here or in Wave but I think the brevity is worthwhile over "inabox" >>>>>>>>>> or >>>>>>>>>> "waveinabox", which feel a bit clumsy. >>>>>>>>>> >>>>>>>>>> Thanks for all the other suggestions too. We need to pick just one >>>>>>>>>> though and I think "box" best captures the community sentiment, with >>>>>>>>>> a nod >>>>>>>>>> to being short and sweet. >>>>>>>>>> >>>>>>>>>> Anyone volunteer to make the renaming patch? >>>>>>>>>> >>>>>>>>>> A. >>>>>>>>>> >>>>>>>>>> On 22 September 2010 10:56, Alex North <[email protected]> wrote: >>>>>>>>>> >>>>>>>>>>> That's a good point about the redundancy in the names. We may >>>>>>>>>>> well shorten the package of the libraries repo to just >>>>>>>>>>> "org/waveprotocol". >>>>>>>>>>> But I don't see why we would move under com/google/wave - we hope >>>>>>>>>>> the >>>>>>>>>>> libraries and Wave in a Box will become as much your project as >>>>>>>>>>> ours. >>>>>>>>>>> >>>>>>>>>>> So >>>>>>>>>>> org/waveprotocol/<something> >>>>>>>>>>> >>>>>>>>>>> client/common (was examples/client/common) >>>>>>>>>>> webclient/ (was examples/client/webclient) >>>>>>>>>>> consoleclient/ (was examples/client/console) >>>>>>>>>>> server/ (was examples/fedone/) >>>>>>>>>>> agents/ (was examples/fedone/agents) >>>>>>>>>>> common/ (for code shared between client and server) >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> org/waveprotocol/ >>>>>>>>>>> >>>>>>>>>>> client/ >>>>>>>>>>> common/ >>>>>>>>>>> concurrencycontrol/ >>>>>>>>>>> crypto/ >>>>>>>>>>> federation/ >>>>>>>>>>> media/ >>>>>>>>>>> model/ >>>>>>>>>>> waveserver/ >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On 21 September 2010 22:59, Tad Glines <[email protected]>wrote: >>>>>>>>>>> >>>>>>>>>>>> The package paths are a bit redundent at the moment (e.g. >>>>>>>>>>>> waveprotocol/wave) so why not shorten "org/waveprotocol/wave" to >>>>>>>>>>>> "org/waveprotocol". And intead of "org/waveprotocol/wave/pirrama", >>>>>>>>>>>> use >>>>>>>>>>>> "com/google/wave". >>>>>>>>>>>> >>>>>>>>>>>> So things could look like: >>>>>>>>>>>> com/google/wave/ >>>>>>>>>>>> >>>>>>>>>>>> client/common (was examples/client/common) >>>>>>>>>>>> webclient/ (was examples/client/webclient) >>>>>>>>>>>> consoleclient/ (was examples/client/console) >>>>>>>>>>>> server/ (was examples/fedone/) >>>>>>>>>>>> agents/ (was examples/fedone/agents) >>>>>>>>>>>> common/ (for code shared between client and server) >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> org/waveprotocol/ >>>>>>>>>>>> >>>>>>>>>>>> client/ >>>>>>>>>>>> common/ >>>>>>>>>>>> concurrencycontrol/ >>>>>>>>>>>> crypto/ >>>>>>>>>>>> federation/ >>>>>>>>>>>> media/ >>>>>>>>>>>> model/ >>>>>>>>>>>> waveserver/ >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> But, if you're dead set on giving it a name, here's some >>>>>>>>>>>> suggestions: >>>>>>>>>>>> >>>>>>>>>>>> ocean >>>>>>>>>>>> wave4j (obligatory but please don't) >>>>>>>>>>>> woscillator (A poor attempt at combining oscillator with wave). >>>>>>>>>>>> moon (because it creates the tides) >>>>>>>>>>>> wind (because it causes the waves) >>>>>>>>>>>> hurricane (because they cause a lot of big waves) >>>>>>>>>>>> Igor (the name of a recent hurricane) >>>>>>>>>>>> >>>>>>>>>>>> -Tad >>>>>>>>>>>> >>>>>>>>>>>> On Thu, Sep 16, 2010 at 11:19 PM, Alex North < >>>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> The example wave server is currently named "FedOne" as its >>>>>>>>>>>>> purpose was to demonstrate federation. We now have grander goals >>>>>>>>>>>>> for this >>>>>>>>>>>>> code though, beginning with the "Wave in a Box" milestone. It's >>>>>>>>>>>>> time for a >>>>>>>>>>>>> new name. Let's rename the "fedone" package in the repository, >>>>>>>>>>>>> removing the >>>>>>>>>>>>> "examples" package while we're there. >>>>>>>>>>>>> >>>>>>>>>>>>> I propose a default repo layout resembling: >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> org/waveprotocol/pirrama/ >>>>>>>>>>>>> >>>>>>>>>>>>> client/common (was examples/client/common) >>>>>>>>>>>>> webclient/ (was examples/client/webclient) >>>>>>>>>>>>> consoleclient/ (was examples/client/console) >>>>>>>>>>>>> server/ (was examples/fedone/) >>>>>>>>>>>>> agents/ (was examples/fedone/agents) >>>>>>>>>>>>> common/ (for code shared between client and server) >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> For reference, the libraries repository provides code >>>>>>>>>>>>> (re-usable for any clients and servers) with the following layout: >>>>>>>>>>>>> org/waveprotocol/wave/ >>>>>>>>>>>>> >>>>>>>>>>>>> client/ >>>>>>>>>>>>> common/ >>>>>>>>>>>>> concurrencycontrol/ >>>>>>>>>>>>> crypto/ >>>>>>>>>>>>> federation/ >>>>>>>>>>>>> media/ >>>>>>>>>>>>> model/ >>>>>>>>>>>>> waveserver/ >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> The name "pirrama" is a placeholder in the new layout - I think >>>>>>>>>>>>> we need a new name to encompass this particular server and bunch >>>>>>>>>>>>> of clients. >>>>>>>>>>>>> waveinabox seems like an obvious candidate, but apart from being >>>>>>>>>>>>> cumbersome >>>>>>>>>>>>> it describes a milestone for the project rather than a particular >>>>>>>>>>>>> product. I >>>>>>>>>>>>> don't think it will age well when we later come to scaling the >>>>>>>>>>>>> system >>>>>>>>>>>>> (though we'll keep "in a box" as a working deployment). >>>>>>>>>>>>> >>>>>>>>>>>>> So - we need a new name. What do you suggest? >>>>>>>>>>>>> >>>>>>>>>>>>> Alex >>>>>>>>>>>>> >>>>>>>>>>>>> * "Pirrama" is the Aboriginal name for "Pyrmont", where the >>>>>>>>>>>>> Google Sydney office is. >>>>>>>>>>>>> >>>>>>>>>>>>> -- >>>>>>>>>>>>> You received this message because you are subscribed to the >>>>>>>>>>>>> Google Groups "Wave Protocol" group. >>>>>>>>>>>>> To post to this group, send email to >>>>>>>>>>>>> [email protected]. >>>>>>>>>>>>> To unsubscribe from this group, send email to >>>>>>>>>>>>> [email protected]<wave-protocol%[email protected]> >>>>>>>>>>>>> . >>>>>>>>>>>>> For more options, visit this group at >>>>>>>>>>>>> http://groups.google.com/group/wave-protocol?hl=en. >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> You received this message because you are subscribed to the >>>>>>>>>>>> Google Groups "Wave Protocol" group. >>>>>>>>>>>> To post to this group, send email to >>>>>>>>>>>> [email protected]. >>>>>>>>>>>> To unsubscribe from this group, send email to >>>>>>>>>>>> [email protected]<wave-protocol%[email protected]> >>>>>>>>>>>> . >>>>>>>>>>>> For more options, visit this group at >>>>>>>>>>>> http://groups.google.com/group/wave-protocol?hl=en. >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> You received this message because you are subscribed to the Google >>>>>>>>>> Groups "Wave Protocol" group. >>>>>>>>>> To post to this group, send email to >>>>>>>>>> [email protected]. >>>>>>>>>> To unsubscribe from this group, send email to >>>>>>>>>> [email protected]<wave-protocol%[email protected]> >>>>>>>>>> . >>>>>>>>>> For more options, visit this group at >>>>>>>>>> http://groups.google.com/group/wave-protocol?hl=en. >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> --Matt >>>>>>>>> >>>>>>>>> -- >>>>>>>>> You received this message because you are subscribed to the Google >>>>>>>>> Groups "Wave Protocol" group. >>>>>>>>> To post to this group, send email to >>>>>>>>> [email protected]. >>>>>>>>> To unsubscribe from this group, send email to >>>>>>>>> [email protected]<wave-protocol%[email protected]> >>>>>>>>> . >>>>>>>>> For more options, visit this group at >>>>>>>>> http://groups.google.com/group/wave-protocol?hl=en. >>>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> You received this message because you are subscribed to the Google >>>>>>>> Groups "Wave Protocol" group. >>>>>>>> To post to this group, send email to [email protected] >>>>>>>> . >>>>>>>> To unsubscribe from this group, send email to >>>>>>>> [email protected]<wave-protocol%[email protected]> >>>>>>>> . >>>>>>>> For more options, visit this group at >>>>>>>> http://groups.google.com/group/wave-protocol?hl=en. >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> --Matt >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> --Matt >>>>>> >>>>>> -- >>>>>> You received this message because you are subscribed to the Google >>>>>> Groups "Wave Protocol" group. >>>>>> To post to this group, send email to [email protected]. >>>>>> To unsubscribe from this group, send email to >>>>>> [email protected]<wave-protocol%[email protected]> >>>>>> . >>>>>> For more options, visit this group at >>>>>> http://groups.google.com/group/wave-protocol?hl=en. >>>>>> >>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "Wave Protocol" group. >>>>> To post to this group, send email to [email protected]. >>>>> To unsubscribe from this group, send email to >>>>> [email protected]<wave-protocol%[email protected]> >>>>> . >>>>> For more options, visit this group at >>>>> http://groups.google.com/group/wave-protocol?hl=en. >>>>> >>>> >>>> >>>> >>>> -- >>>> --Matt >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Wave Protocol" group. >>>> To post to this group, send email to [email protected]. >>>> To unsubscribe from this group, send email to >>>> [email protected]<wave-protocol%[email protected]> >>>> . >>>> For more options, visit this group at >>>> http://groups.google.com/group/wave-protocol?hl=en. >>>> >>> >>> -- >>> You received this message because you are subscribed to the Google Groups >>> "Wave Protocol" group. >>> To post to this group, send email to [email protected]. >>> To unsubscribe from this group, send email to >>> [email protected]<wave-protocol%[email protected]> >>> . >>> For more options, visit this group at >>> http://groups.google.com/group/wave-protocol?hl=en. >>> >> >> >> >> -- >> --Matt >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Wave Protocol" group. >> To post to this group, send email to [email protected]. >> To unsubscribe from this group, send email to >> [email protected]<wave-protocol%[email protected]> >> . >> For more options, visit this group at >> http://groups.google.com/group/wave-protocol?hl=en. >> > > -- > You received this message because you are subscribed to the Google Groups > "Wave Protocol" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]<wave-protocol%[email protected]> > . > For more options, visit this group at > http://groups.google.com/group/wave-protocol?hl=en. > -- --Matt -- You received this message because you are subscribed to the Google Groups "Wave Protocol" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/wave-protocol?hl=en.
