I've submitted a patch [0] that changes the contructor arg from String[] to InetSocketAddress[] for ServerRpcProvider, and modified WebSocketRpcTest to take advantage of the changed type to specify port 0.
[0] http://codereview.waveprotocol.org/280001 -Tad On Tue, Nov 2, 2010 at 4:32 PM, Tad Glines <[email protected]> wrote: > That will require a patch because my parse code currently won't accept port > 0. > > -Tad > > > On Tue, Nov 2, 2010 at 4:29 PM, Anthony Baxter <[email protected]>wrote: > >> The test that's failing: >> >> public class WebSocketRpcTest extends RpcTest { >> >> @Override >> protected void startServer() { >> SessionManager sessionManager = Mockito.mock(SessionManager.class); >> server = new ServerRpcProvider(null, new String[] {"localhost:9898"}, >> sessio >> nManager, null); >> server.startWebSocketServer(); >> } >> >> @Override >> protected ClientRpcChannel newClient() throws IOException { >> return new WebSocketClientRpcChannel(server.getWebSocketAddress()); >> } >> } >> >> If there's a server running already, the ServerRpcProvider ctor will >> fail, leaving the port number as -1. Pick an unallocated port - use >> port 0, and the O/S should allocate one at random. >> >> Anthony >> >> >> On Wed, Nov 3, 2010 at 10:10, Lennard de Rijk <[email protected]> >> wrote: >> > >> > >> > On Tue, Nov 2, 2010 at 4:06 PM, James Purser <[email protected]> >> wrote: >> >> >> >> Just got the latest source pulled down (includes Tads Multiple Listener >> >> code) and got the following error on build: >> >> test: >> >> [junit] WARNING: multiple versions of ant detected in path for >> junit >> >> [junit] >> >> >> jar:file:/usr/share/java/ant-1.7.1.jar!/org/apache/tools/ant/Project.class >> >> [junit] and >> >> >> jar:file:/home/purserj/wave-devel/wave-protocol/third_party/codegen/gwt/gwt-dev.jar!/org/apache/tools/ant/Project.class >> >> [junit] TEST org.waveprotocol.box.server.rpc.WebSocketRpcTest >> FAILED >> >> [junit] Tests FAILED >> >> [junitreport] Processing >> >> >> /home/purserj/wave-devel/wave-protocol/build/testoutput/TESTS-TestSuites.xml >> >> to /tmp/null1229948038 >> >> [junitreport] Loading stylesheet >> >> >> jar:file:/usr/share/java/ant/ant-junit-1.7.1.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl >> >> [junitreport] Transform time: 11705ms >> >> [junitreport] Deleting: /tmp/null1229948038 >> > >> > Hudson is showing the same, [0]. >> > Greetings, >> > Lennard >> > [0] http://google2.osuosl.org:9090/job/default/116/ >> > >> > -- >> > You received this message because you are subscribed to the Google >> Groups >> > "Wave Protocol" group. >> > To post to this group, send email to [email protected]. >> > To unsubscribe from this group, send email to >> > [email protected]<wave-protocol%[email protected]> >> . >> > For more options, visit this group at >> > http://groups.google.com/group/wave-protocol?hl=en. >> > >> >> >> >> -- >> Anthony Baxter, [email protected] >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Wave Protocol" group. >> To post to this group, send email to [email protected]. >> To unsubscribe from this group, send email to >> [email protected]<wave-protocol%[email protected]> >> . >> For more options, visit this group at >> http://groups.google.com/group/wave-protocol?hl=en. >> >> > -- You received this message because you are subscribed to the Google Groups "Wave Protocol" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/wave-protocol?hl=en.
