The OpenJDK java compiler doesn't seem to like UTF-8 characters in
source code files if the system's LOCALE isn't set up for UTF-8.
Everybody should be using a UTF-8 locale these days; but POSIX is
still the default for headless debian/ubuntu install. And that means,
if you provision a box using slicehost (and probably others), you'll
see waveinabox compile warnings like these:
compile:
[javac] Compiling 231 source files to
/home/josephg/src/wave-protocol/build/core
[javac]
/home/josephg/src/wave-protocol/src/org/waveprotocol/box/server/robots/dataapi/DataApiOAuthServlet.java:148:
warning: unmappable character for encoding ASCII
[javac] OAuth.formEncode(OAuth.newList( // ???
[javac] ^
[javac]
/home/josephg/src/wave-protocol/src/org/waveprotocol/box/server/robots/dataapi/DataApiOAuthServlet.java:148:
warning: unmappable character for encoding ASCII
[javac] OAuth.formEncode(OAuth.newList( // ???
[javac] ^
...
And because we have -Werror turned on, they make the compile fail.
There are three options here, none of which is particularly appealing:
1. Insist everyone has a UTF-8 locale.
To see your locale, type this:
% locale
If you see lines ending in UTF-8, you're ok. If they say 'POSIX',
you'll have problems.
To set your locale on ubuntu, edit (or create) /etc/default/locale and
set it to this:
LANG="en_US.UTF-8"
... and re-login.
2. Turn of -Werror.
They're 'only' compiler warnings. We can be less strict...
3. Disallow unicode characters in the repository.
For now, we're going to disallow unicode characters since there's not
that many of them anyway, and want people who install WIAB at the
summit to not have any problems.
-J
http://codereview.waveprotocol.org/285001
--
You received this message because you are subscribed to the Google Groups "Wave
Protocol" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/wave-protocol?hl=en.
