There are a quite a few Java 6-isms in the Wave codebase. IIRC correctly they include the use of some library classes added in 1.6, and the sane use of @Override annotations on methods implementing interfaces.
I personally feel it would be a worthwhile trade to just change the String.isEmpty() uses in return for easily targeting Android, but restricting the others would be much more painful. OTOH, does anyone know if Android plans to support Java 6 any time soon? On 28 November 2010 11:22, Davide Carnovale < [email protected]> wrote: > Hi all, > I'm working on a special purpouse android client that uses the wave > protocol libraries. > Unfortunately, there is a large use of java.lang.String.isEmpty() but > such method is available only form java 1.6, while android supports > only java 1.5. > > so i would like a little advice, will using String.length() == 0 > instead of String.isEmpty() cause any problem? (so far it's working ok > for me) > > and would you accept such a patch mainstream if i replace all the > occurencies of String.isEmpty() with String.length() == 0? > > -- > You received this message because you are subscribed to the Google Groups > "Wave Protocol" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]<wave-protocol%[email protected]> > . > For more options, visit this group at > http://groups.google.com/group/wave-protocol?hl=en. > > -- You received this message because you are subscribed to the Google Groups "Wave Protocol" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/wave-protocol?hl=en.
