https://bugzilla.gnome.org/show_bug.cgi?id=744932
Owen Taylor <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #310996|none |reviewed
status| |
--- Comment #132 from Owen Taylor <[email protected]> ---
Review of attachment 310996:
One vfunc needs a rename to be consistent, otherwise good to commit
::: src/wayland/meta-wayland-pointer.c
@@ +806,3 @@
+ if (cursor_sprite == meta_cursor_tracker_get_displayed_cursor
(cursor_tracker))
+ meta_cursor_renderer_force_update (cursor_renderer);
Don't see what this has to do with this commit, but OK
@@ +982,3 @@
+static gboolean
+is_cursor_surface_role_on_monitor (MetaWaylandSurfaceRole *role,
Don't make up arbitrary names here - this should be:
surface_role_is_on_output
@@ +993,3 @@
+ MetaWaylandSurfaceRoleCursor *cursor_role =
+ META_WAYLAND_SURFACE_ROLE_CURSOR (surface->role);
+ MetaCursorSprite *displayed_cursor_sprite;
No change needed, but I wanted to mention that there is no line length limit in
Mutter source code, and the goal of introducing line breaks is to maximize
readability.
--
You are receiving this mail because:
You are on the CC list for the bug._______________________________________________
wayland-bugs mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/wayland-bugs
