https://bugzilla.gnome.org/show_bug.cgi?id=757558

--- Comment #6 from Carlos Garnacho <[email protected]> ---
(In reply to Milan Crha from comment #5)
> Sure, for the emoticon it's created here:
> https://git.gnome.org/browse/evolution/tree/e-util/e-emoticon-tool-button.
> c#n573
> and repositioned here:
> https://git.gnome.org/browse/evolution/tree/e-util/e-emoticon-tool-button.
> c#n124
> 
> I compared the code with the one for GtkComboBox and it seems to me it's
> pretty much the same, except we hold the popup window for the whole lifetime
> of the widget, while GtkComboBox seems to build and destroy the popup on
> demand.
> 
> Please note that the X11 works properly, with the same code in the evolution.

Thanks!

I see that you're setting the transient_for on the popup conditionally around
https://git.gnome.org/browse/evolution/tree/e-util/e-emoticon-tool-button.c#n581
 . At that time the toplevel will still be NULL, so that if() is never stepped
in.

The transient_for window is essential for popups to appear properly positioned
in wayland, so that needs to be done at some point when the button has a
toplevel, maybe hierarchy_changed(), or before showing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
wayland-bugs mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/wayland-bugs

Reply via email to