https://bugzilla.gnome.org/show_bug.cgi?id=762120
Ray Strode [halfline] <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #321340|none |accepted-commit_now
status| |
--- Comment #4 from Ray Strode [halfline] <[email protected]> ---
Review of attachment 321340:
so this looks fine to me, but it does nicely illustrate an interesting point: a
commit operation could be one or more different things. I wonder if a cleaner
approach than adding another boolean, would be to change the pending_commit
variable to take a bitfield of commit flags instead? Then you could set
pending_commit |= PENDING_DAMAGE; pending_commit |= PENDING_BUFFER_ATTACHMENT;
pending_commit |= SUBSURFACE_SET_POSITION etc etc.
and inside on_frame_clock_after_paint you could do
if (pending_commit & PENDING_DAMAGE)
read_back_cairo_surface (...)
...
if (pending_commit & PENDING_BUFFER_ATTACHMENT)
impl->committed_cairo_surface = ...
just an idea, what you've got seems fine.
--
You are receiving this mail because:
You are on the CC list for the bug._______________________________________________
wayland-bugs mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs
