https://bugzilla.gnome.org/show_bug.cgi?id=780820
Jonas Ådahl <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #366553|none |reviewed
status| |
--- Comment #24 from Jonas Ådahl <[email protected]> ---
Review of attachment 366553:
::: src/core/window-private.h
@@ +701,3 @@
void meta_window_frame_size_changed (MetaWindow *window);
+gboolean meta_window_in_stack (MetaWindow *window);
better name (follows convention):
meta_window_is_in_stack(). Alternatively meta_window_is_stacked().
::: src/core/window.c
@@ +1701,3 @@
+ /* If showing a window that wasn't added to the stack yet, make sure we
+ * add it to the stack now.
+ * See #780820
This comment just spells out what the statement below does. Suggestion:
/* Some windows are not stackable until being showed, so add those now. */
(the bug link (number will be ambiguous with the move to gitlab (even though we
hopefully won't have 780k bugs just on mutter!) will be easily discoverable
using git annotate)
@@ +6908,3 @@
+meta_window_in_stack (MetaWindow *window)
+{
+ return (window->stack_position >= 0);
why the ( and )?
::: src/wayland/meta-window-wayland.c
@@ +547,3 @@
+meta_window_wayland_is_stackable (MetaWindow *window)
+{
+ /* Surface without a buffer attached yet should not be added to the stack */
This comment spells out what is done below so no need for it.
@@ +548,3 @@
+{
+ /* Surface without a buffer attached yet should not be added to the stack */
+ return (meta_wayland_surface_get_buffer (window->surface) != NULL);
Why the ( and )?
::: src/x11/window-x11.c
@@ +1554,3 @@
+{
+ /* For X11, do not add OR windows to the stack */
+ return (!window->override_redirect);
Same here about the comment being the line of code but in english, and about
the ( and ).
--
You are receiving this mail because:
You are on the CC list for the bug._______________________________________________
wayland-bugs mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs
