On Sat, 9 Mar 2013 12:29:43 -0800 Daniel Stone <[email protected]> wrote:
> Hi, > > On 9 March 2013 07:24, Scott Moreau <[email protected]> wrote: > > > diff --git a/hw/xfree86/xwayland/xwayland.c > > b/hw/xfree86/xwayland/xwayland.c > > index d97f4ee..f59bfe4 100644 > > --- a/hw/xfree86/xwayland/xwayland.c > > +++ b/hw/xfree86/xwayland/xwayland.c > > @@ -344,6 +344,9 @@ void xwl_screen_post_damage(struct xwl_screen > > *xwl_screen) > > box->x2 - box->x1 + 1, > > box->y2 - box->y1 + 1); > > } > > + wl_surface_attach(xwl_window->surface, > > + xwl_window->buffer, > > + 0, 0); > > wl_surface_commit(xwl_window->surface); > > DamageEmpty(xwl_window->damage); > > } > > > > I think this is just a broken compositor as a result of the patches to not > attach on every commit though; I guess we should take damage into account > when we process that, doing something akin to TexSubImage if possible. The > protocol seems to explicitly allow for damage without an explicit attach. Except not anymore. Krh committed a patch to weston to require explicit attaches, and I later sent a patch to fix the protocol accordingly. http://cgit.freedesktop.org/wayland/weston/commit/?id=e7144fd175d1d68b91aa0cec7ab63381b79385a9 http://lists.freedesktop.org/archives/wayland-devel/2013-March/007802.html Scott's patch looks fine to me for what I know. Thanks, pq _______________________________________________ wayland-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/wayland-devel
