Hi Rafael, Right now when the implicit grab that the popup takes is broken the compositor emits popup_done on the shell_surface. We now have a better idiom for doing this by returning a new object from set_popup that would be using a new interface that has a "done" event on that interface. This means that the popup_done can be removed from the shell surface interface itself.
This isn't necessary for transient role surfaces as unlike popups these do not create a grab in the compositor and hence there is no need for a mechanism for the compositor to tell the client that the grab is over. Rob On 8 July 2013 19:04, Rafael Antognolli <[email protected]> wrote: > On Mon, Jul 8, 2013 at 11:56 AM, Rob Bradford <[email protected]> > wrote: >> If we're talking changes... >> >> Let's make the popup return an object with a done event on rather than >> stick the event in the interface like popup_done is. > > So, you want that set_popup automatically sending a done event after > called? Then set_transient should also do the same, right? > > Anyway, I can do it in a change after this one, since here I'm just > copying the files and changing the names, right? > > Or maybe I didn't get what you want... > >> I'd also like to see us standardise on the naming of the request to >> create the new object - I think create_xdg_surface is better than >> get_xdg_surface and aligns with the create_surface request on >> wl_compositor. > > OK, added that to the new patch. We end up with: > > interface: xdg_shell > - function create_xdg_surface > > interface: xdg_surface > > Is this good? > > Ah, the new patch went to another thread, I guess that I should have > used --chain-reply-to to avoid that. > > Regards, > -- > Rafael Antognolli _______________________________________________ wayland-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/wayland-devel
