Hi,

On 19 August 2014 11:25, Giulio Camuffo <giuliocamu...@gmail.com> wrote:

> This adds a function weston_keyboard_set_leds() which can be used
> to change the state of the num lock and the caps lock leds.
> Only the evdev backend supports this, since it doesn't make sense
> for embedded sessions.
>

This is missing the bit for actual evdev support, as well as a user. Please
also move the variable declarations to the top of the function. The
leds/active naming is a bit confusing too; something about mask/value would
be nice, as well as getting rid of the complex ternary statements.

Other than that, looks good to me, thanks.

Cheers,
Daniel
_______________________________________________
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Reply via email to