Hi, On 08/28/2014 03:12 PM, Hans de Goede wrote: > Hi, > > On 08/27/2014 06:31 AM, Peter Hutterer wrote: >> WL_CALIBRATION is a weston-specific property that required the translation >> component of the matrix to be in pixels. libinput can't provide calibration >> based on unknown outputs, so drop support for this property. >> >> The basic functionality is maintained, renaming just makes the change in >> behavior more explicit. >> >> Signed-off-by: Peter Hutterer <[email protected]> >> --- >> Not sure if we want to do this. I'm somewhat tempted to push all WL_* >> property parsing to the compositor and _not_ have a back-channel for >> configuration in libinput. >> As our brief stint with HAL in Xorg has shown, shoving configuration into a >> different project does not make things easier. > > I think this may be useful for systemwide calibration data, otoh there may be > cases where there are different calibration profiles and the compositor needs > to give us the one which should be used. > > I think that having support for system-wide calibration data through udev > directly > in libinput is not necessarily bad, as long as we also have a config > interface to > allow the compositor to override the calibration matrix.
p.s. The rename itself makes sense: Reviewed-by: Hans de Goede <[email protected]> Regards, Hans > > Regards, > > Hans > > > >> >> src/udev-seat.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/udev-seat.c b/src/udev-seat.c >> index 2947e71..d0324dd 100644 >> --- a/src/udev-seat.c >> +++ b/src/udev-seat.c >> @@ -90,7 +90,7 @@ device_added(struct udev_device *udev_device, struct >> udev_input *input) >> >> calibration_values = >> udev_device_get_property_value(udev_device, >> - "WL_CALIBRATION"); >> + "LIBINPUT_CALIBRATION_MATRIX"); >> >> if (calibration_values && sscanf(calibration_values, >> "%f %f %f %f %f %f", >> _______________________________________________ wayland-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/wayland-devel
