On 12/17/2014 02:10 PM, Peter Hutterer wrote:
>> diff --git a/configure.ac b/configure.ac
>> index 33e380c..329f224 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -76,6 +76,15 @@ else
>>  fi
>>  AM_CONDITIONAL([HAVE_DOXYGEN], [test "x$have_doxygen" = "xyes"])
>>  
>> +AC_PATH_PROG(DOT, dot)
>> +if test "x$DOT" = "x"; then
>> +    AC_MSG_WARN([Graphviz's dot not found - required for documentation])
>> +    have_dot="no"
>> +else
>> +    have_dot="yes"
>> +fi
>> +AM_CONDITIONAL([HAVE_DOT], [test "x$have_dot" = "xyes"])
>> +
> 
> you don't seem to be using HAVE_DOT anywhere. I think we should just
> group doxygen and dot together into a --enable-documentation=auto switch
> with the usual behaviour: default is autodetect, yes requires the packages,
> no ignores it.
> 

Yeah, I was considering that. However for consistency and for expanded
use there are reasons to keep that HAVE_DOT in. Among those are keeping
things simple for people to copy-n-paste to different projects or
subprojects.


_______________________________________________
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Reply via email to